224857 - Remove browser dependencies in the toolkit

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Pierre Chanial]

> grep -slr "chrome://browser" mozilla/toolkit
mozilla/toolkit/content/customizeToolbar.xul
mozilla/toolkit/locale/about.xhtml
mozilla/toolkit/mozapps/downloads/content/pref-downloads.js

there may be more insidious ones.

Comment 1

[Steffen Wilberg]

I've got two new files:
mozilla/toolkit/mozapps/downloads/content/downloads.js
mozilla/toolkit/mozapps/downloads/content/downloads.xul

Comment 2

[Simon Paquet [:sipaq]]

*** Bug 249720 has been marked as a duplicate of this bug. ***

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

This bug isn't purely cosmetical. It makes having customizable toolbars in
sunbird impossible without otherwise needless code duplication.

Comment 4

[alanjstr]

Is this still valid?

Comment 5

[Mike Connor [:mconnor]]

not a 1.0 blocker, detangling should happen on the trunk.

Comment 6

[Daniel C]

Current results:

djc@dan ~ $ grep --recursive 'chrome://browser' /home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/;
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/content/customizeToolbar.xul:<?xml-stylesheet href="chrome://browser/skin/" type="text/css"?>
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/content/customizeToolbar.xul:<?xml-stylesheet href="chrome://browser/content/browser.css" type="text/css"?>
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/downloads/content/downloads.js:    openDialog("chrome://browser/content/pref/pref.xul", "PrefWindow",
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/update.xml:        ww.openWindow(null, "chrome://browser/content/browser.xul",
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/extensions.js:  openDialog("chrome://browser/content/browser.xul", "_blank", "chrome,all,dialog=no", aURL, null, null);
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/themes/gnomestripe/global/autocomplete.css:  -moz-binding: url(chrome://browser/skin/browser.xml#autocomplete-security-wrapper);
djc@dan ~ $

djc@dan ~ $ grep --recursive 'MOZ_PHOENIX' /home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/;
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/xre/nsNativeAppSupportWin.h:#ifdef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/components/viewsource/content/viewSource.js:#ifdef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/components/viewsource/content/viewSource.js:#ifdef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/components/viewsource/content/viewSource.xul:#ifdef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/components/printing/content/printUtils.js:#ifdef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/update.xml:#ifndef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/extensions.xul:#ifndef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/extensions.xul:#ifndef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/extensions.js:#ifndef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/extensions.js:#ifndef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/extensions.js:#ifndef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/extensions/content/extensions.js:#ifdef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/installer/windows/wizard/setup/setup.h:#ifdef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/mozapps/installer/windows/wizard/uninstall/uninstall.h:#ifdef MOZ_PHOENIX
/home/djc/mozilla-stuff/mozilla/sources/mozilla/toolkit/profile/Makefile.in:ifndef MOZ_PHOENIX
djc@dan ~ $

Comment 7

[Phil Ringnalda (:philor)]

> Is this still valid?

Not really - it would only be useful as a tracking bug, if people actually filed bugs (and fixed them) rather than pasting in their grep output, but despite having just started to use it that way, I don't think it's really worthwhile. We mostly know better, and behave better, now, and there's no point in making anyone think that it will do any good to do anything other than file a precise and fixable bug when they get bit by a failure to remember that Firefox != Toolkit.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

I don't see any proof that we know better now: the list has just become much longer, thanks to places.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

A new bug should be filed specifically for the places dependencies.

Comment 10

[Phil Ringnalda (:philor)]

Filed bug 365573. mvl, be as bitter as you want to be, but I've seen lots of patches get r- because they would cause bad dependency, and I'm doing my damndest to fix the mistakes we've made, and unfork the results, and in the spectacularly unlikely case that someone actually needs to use Places, but doesn't know how to de-browser/ it themselves, I'll figure out how to fix that, too.

And, you're welcome.