Typo in spellchecker code

RESOLVED FIXED

Status

SeaMonkey
Composer
--
critical
RESOLVED FIXED
15 years ago
14 years ago

People

(Reporter: Philip K. Warren, Assigned: mkaply)

Tracking

({crash})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
http://webtools.mozilla.org/bonsai/cvsblame.cgi?file=mozilla/extensions/spellcheck/myspell/src/mozMySpell.cpp&root=/cvsroot&rev=1.2&mark=151-172&#150

It looks like in the code above, the line:

if(aLanguage){
  res = NS_ERROR_NULL_POINTER;
}

should be changed to:

if(!aLanguage){
  res = NS_ERROR_NULL_POINTER;
}

Comment 1

15 years ago
r=me i have this in a tree somewhere, i actually crashed because of it.

Updated

15 years ago
Severity: normal → critical
Keywords: crash
(Reporter)

Comment 2

15 years ago
Created attachment 135032 [details] [diff] [review]
Patch v1
(Reporter)

Updated

15 years ago
Attachment #135032 - Flags: superreview?(mkaply)
Attachment #135032 - Flags: review?(timeless)
(Assignee)

Comment 3

15 years ago
Comment on attachment 135032 [details] [diff] [review]
Patch v1

timeless already r=
sr=me since I kind of own spellchecker
Attachment #135032 - Flags: superreview?(mkaply)
Attachment #135032 - Flags: superreview+
Attachment #135032 - Flags: review?(timeless)
Attachment #135032 - Flags: review+
(Reporter)

Comment 4

15 years ago
Fixed: 

Checking in mozMySpell.cpp;
/cvsroot/mozilla/extensions/spellcheck/myspell/src/mozMySpell.cpp,v  <-- 
mozMySpell.cpp
new revision: 1.3; previous revision: 1.2
done
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 5

15 years ago
So, is this bugfix can kill bug 225361 "Spellchecker crash" ?
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.