225003 - Typo in spellchecker code

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Philip K. Warren]

http://webtools.mozilla.org/bonsai/cvsblame.cgi?file=mozilla/extensions/spellcheck/myspell/src/mozMySpell.cpp&root=/cvsroot&rev=1.2&mark=151-172&#150

It looks like in the code above, the line:

if(aLanguage){
  res = NS_ERROR_NULL_POINTER;
}

should be changed to:

if(!aLanguage){
  res = NS_ERROR_NULL_POINTER;
}

Comment 1

[timeless]

r=me i have this in a tree somewhere, i actually crashed because of it.

Comment 2

[Philip K. Warren]

Attachment: Patch v1

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 135032 [details] [diff] [review]
Patch v1

timeless already r=
sr=me since I kind of own spellchecker

Comment 4

[Philip K. Warren]

Fixed: 

Checking in mozMySpell.cpp;
/cvsroot/mozilla/extensions/spellcheck/myspell/src/mozMySpell.cpp,v  <-- 
mozMySpell.cpp
new revision: 1.3; previous revision: 1.2
done

Comment 5

[Frederic Bezies]

So, is this bugfix can kill bug 225361 "Spellchecker crash" ?