225042 - If sendmail dies while processing a duplicate it corrupts the duplicates table

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Ning Cao]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

Bugzilla sends emails when a bug is marked as duplicated.

When it failes to connect to SMTP server, an error message is printed in red.
Unfortunately, it failed to insert data into duplicates table, thus cause the
follwing line to be displayed when running sainty check:

Bug(s) found marked resolved duplicate and not on duplicates table: 1229, 1247, ...

And, when I go to the bug 1229, the following message appeared and I could not
get the information:

URL: http://192.126.9.205/bugzilla-2.17.4/show_bug.cgi?id=1229
undef error - GetBugLink() called with non-integer bug number at
D:/Perl/lib/CGI/Carp.pm line 301.

I found that data has been added to bugs, bugs_activity and longdescs table, but
the item is missing in duplicates table.

Now, I have to lookup the longdescs table to fix the invalid items.


Reproducible: Always

Steps to Reproduce:
1. Turn the email sending for the bug owners
2. Set the SMTP server to forbid the access of bugzilla
3. Mark a bug(#a) as duplicated to another one(#b)
4. Running sainty check or visit bug #a or #b

Actual Results:  
item is missing in duplicates table.

Expected Results:  
Just like other functions, send mail after all the database operation has finished.

Using Win2000, I have changed the source code a little to send emails:

In CGI.pl

#    open SENDMAIL, "|/usr/lib/sendmail -t -i";
#    print SENDMAIL $msg;
#    close SENDMAIL;
use Net::SMTP;
my $smtp_server = '127.0.0.1';  # change this

my $smtp = Net::SMTP->new($smtp_server) ||
  die 'Cannot connect to server \'$smtp_server\'';

$smtp->mail('[e-mail]');  # change this
$smtp->to($login);
$smtp->data();
$smtp->datasend($msg);
$smtp->dataend();
$smtp->quit;

The smtp server I use is IIS.

Comment 1

[Dave Miller [:justdave]]

Reproduced on landfill with the current (non-modified) mail architecture.  If
anything goes wrong trying to call Sendmail while marking a dupe, it corrupts
the duplicates table.

This is actually in the mail notification code where it's dying, so passing off
to JayPee.

Believe it or not, this does not affect 2.16.4 because processmail is a separate
process, so when it dies, process_bug just keeps going after printing the error
message.

Comment 2

[Dave Miller [:justdave]]

All 2.18 bugs that haven't been touched in over 60 days and aren't flagged as
blockers are getting pushed out to 2.20

Comment 3

[Max Kanat-Alexander]

As preed is no longer actively working on Bugzilla (from what I know), I somehow
doubt that this bug will make it in for 2.20. :-) If I'm wrong, feel free to
take it back and re-target it. :-)

Comment 4

[Frédéric Buclin]

Attachment: untested patch, v1

Do all required changes to the DB before sending emails.

Comment 5

[Vlad Dascalu]

Comment on attachment 185618 [details] [diff] [review]
untested patch, v1

Reviewing patch per LpSolit's request.

This looks good. I don't have Sendmail installed so I can't test it.

There isn't any more processing done after the dependency stuff, and the code
is simply moved from one place to another, so there's nothing to go wrong here
(meaning it's pretty low-risk).

Comment 6

[Dave Miller [:justdave]]

This patch does not apply cleanly on the 2.18 branch

Comment 7

[Frédéric Buclin]

Attachment: patch for 2.18.1, v1

backport. Same patch (modulo some nits such as line length)

Comment 8

[Vlad Dascalu]

Comment on attachment 185704 [details] [diff] [review]
patch for 2.18.1, v1

> backport. Same patch (modulo some nits such as line length)

D'oh.

Comment 9

[Frédéric Buclin]

Tip:

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.257; previous revision: 1.256
done


2.18.1:

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.205.2.21; previous revision: 1.205.2.20
done