225067 - solitary carriage returns in mail/extensions/Makefile.in

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Malte Rücker (mbr)]

My build failed because the file mail/extensions/Makefile.in (and the resulting
Makefile) had some extra carriage returns (0x0d) in them. They appear after the
lines from the recent checkin. Removing them fixed the problem.

Comment 1

[Malte Rücker (mbr)]

Attachment: patch to remove the cr's

this hopefully fixes the line endings.

Comment 2

[Malte Rücker (mbr)]

I was using
ac_add_options --enable-extensions=inspector
for that build, I suppose the build process won't break without that option.

Comment 3

[Malte Rücker (mbr)]

Is there anything special that's preventing this from being checked in? If the
patch doesn't solve the issue maybe someone else could provide one?

Comment 4

[Scott MacGregor]

i apply it and cvs says there are no changes in the file and nothing gets
committed. I have not figured out a way to remove these line endings and have
them get committed.

Comment 5

[Malte Rücker (mbr)]

that's ugly :-/ but thanks for your reply, at least I know that there are problems.
Funny that the diff shows differences but they cannot be committed...

Comment 6

[Kevin Teuscher]

Scott,
Are you using cygwin on your windows box? and if so, which mode is the mount
where your tree located?  CVS writes line endings according to the system it is
run on, so if your mount is in "text" mode, cvs may translate line endings into
CRLF pairs, hence no change to the file.  I use binmode so that I don't have
these problems.

Kevin

Comment 7

[Malte Rücker (mbr)]

Your recent checkin fixed it!
Anyway, now there's another file breaking the build process for me: it's
mail/config/Makefile.in, line 86.

Comment 8

[Malte Rücker (mbr)]

Attachment: trying to fix mail/config/Makefile.in

Though it seems I am the only one having problems with these ^M's when
building, it would be nice if you could try to fix the mail/config/Makefile.in
for the upcoming 0.4 release/sources.

The patch probably won't work (like the last time) but maybe you can use some
other tricks (voodoo?) again :)

Comment 9

[Scott MacGregor]

let's try having you send me a complete Makefile.in replacement? Maybe that will
work.

Comment 10

[Malte Rücker (mbr)]

thanks a lot, Scott, they are removed now. Great!