225106 - remove redundant charset alias resolution in charset converter manager

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jungshik Shin]

I just found that there's a redundant call to GetCharsetAlias in
GetCharsetLangGroupRaw in nsCharsetConverterManager. |GetCharsetLangGroup| calls
GetCharsetAlias before calling GetCharsetLangGroupRaw so that
GetCharsetLangGroupRaw shouldn't call it again.

Comment 1

[Jungshik Shin]

Attachment: patch

Comment 2

[Jungshik Shin]

Comment on attachment 135099 [details] [diff] [review]
patch

asking for r/sr.

this redundancy should have been caught when alecf changed the file, but
somehow it was missed.

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 135099 [details] [diff] [review]
patch

r=smontagu

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 135099 [details] [diff] [review]
patch

sr=bzbarsky

Comment 5

[Alec Flett]

Comment on attachment 135099 [details] [diff] [review]
patch

oh! nice. sr=alecf

but wait, this doesn't actually remove any redudnant code, except in case of
failure. is there a better way to structure this?

Comment 6

[Jungshik Shin]

Thanks for quick r/sr. Fix checked into the trunk.

alecf, without the patch, there were _two_ calls to GetCharsetAlias() in most
cases.  Most consumers call GetCharsetLangGroup which resolves charset alias and
then just passes the resolved charset to GetCharsetLangGroupRaw. Without the
patch, GetCharsetLangGroupRaw calls once again GetCharsetAlias (even though what
it receives is already resolved), which is a waste. Besides, a few consumers who
call GetCharsetLangGroupRaw (because they know what they have is already
resolved) wouldn't benefit from calling Raw version.