225163 - Win32 compile error on dialogs.c (Thunderbird & Firebird)

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[David G King]

Building Thunderbird (pulled 10/11/2003) I get compile errors using MinGW gcc.

The first error (after several warnings) is that
thunderbird/mozilla/toolkit/mozappd/installer/windows/wizard/setup/dialogs.c has
an error on line 69 "PSP_HIDEHEADER undeclared). A quick search on LXR shows
this used in two places in the same file, but no declaration.

I also get messages about PSP_USEHEADERTITLE, PSP_USEHEADERSUBTITLE,
PSH_WIZARD97, PSH_WATERMARK and PSH_HEADER.

Comment 1

[Matthias Versen [:Matti]]

Thunderbird!=Mailnews 
-> Firebird:Installer


Please select the right component the next time

Comment 2

[David G King]

It isn't an error with installing Firebird. It's an error on building Thunderbird.

Changing to Thunderbird:Build-config.

Comment 3

[Scott MacGregor]

hmm I don't see this error on my win32 build. I use msdev as my compiler. maybe
it's a mingwcc thing which I know nothing about. In that case you this should
happen with firebird too and should probably be afirebird installer but since
thunderbird doesn't use the installer yet but firebird does.

Comment 4

[David G King]

After some fiddling with my Firebird build setup, I can see this same error on
Firebird.

Adding cls to see if he has any ideas on this gcc problem.

Comment 5

[Scott MacGregor]

moving to the right owner. ben owns this

Comment 6

[David G King]

From some looking around, it appears that the code needs an Include of prsht.h

MinGW has this file, but I'm not sure if Cygwin has it.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

PSP_*/PSH_* are standard windows header defines. Don't use a crappy compiler ;-) 

Comment 8

[David G King]

You're right, I should be using Microsoft products, including their browser ;-)

Comment 9

[David G King]

Attachment: Patch v1.0

Patch to allow building with GCC and MINGW.

Comment 10

[David G King]

Comment on attachment 136905 [details] [diff] [review]
Patch v1.0

Could you review this for me?

Comment 11

[Brian Ryner (not reading)]

Comment on attachment 136905 [details] [diff] [review]
Patch v1.0

as long as it doesn't break msvc, r=bryner.

Comment 12

[David G King]

Thanks for the "R". I haven't tested MSVC, however I will do so before I ask for
a "SR".

Comment 13

[David G King]

Further to my comment #12, if someone would like to test this patch with MSVC,
please feel free to do so. Converting my build environment from gcc/MinGW/cygwin
to MSVC is going to be a fun process.

Comment 14

[David G King]

Comment on attachment 136905 [details] [diff] [review]
Patch v1.0

This patch doesn't break msvc (tested with Visual C v6sp5).

Asking Ben for SR and to checkin on my behalf (I don't have checkin rights
yet).

Comment 15

[cls]

A slightly cleaned up version of the patch has been checked in.