Last Comment Bug 225260 - Link NSPR dynamic shared libraries with the -headerpad_max_install_names option
: Link NSPR dynamic shared libraries with the -headerpad_max_install_names option
Status: RESOLVED FIXED
:
Product: NSPR
Classification: Components
Component: NSPR (show other bugs)
: 4.4
: PowerPC Mac OS X
: -- normal (vote)
: 4.4.1
Assigned To: Wan-Teh Chang
: Wan-Teh Chang
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2003-11-10 13:24 PST by Wan-Teh Chang
Modified: 2003-12-22 14:15 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed patch (766 bytes, patch)
2003-11-10 14:00 PST, Wan-Teh Chang
ccarlen: review+
sfraser_bugs: superreview+
Details | Diff | Splinter Review

Description Wan-Teh Chang 2003-11-10 13:24:25 PST
We should link the NSPR dynamic shared libraries with
the -headerpad_max_install_names linker option so that
their install names can be changed with install_name_tool.

See the ld(1) man page on Mac OS X for documentation on
-headerpad_max_install_names.
Comment 1 Wan-Teh Chang 2003-11-10 14:00:07 PST
Created attachment 135199 [details] [diff] [review]
Proposed patch

Note that $(DSO_LDOPTS) is passed to the compiler $(CC) in
the MKSHLIB command, but it seems that I don't need to use
"-Wl," in front of -headerpad_max_install_names.
Comment 2 Simon Fraser 2003-11-10 14:15:59 PST
Comment on attachment 135199 [details] [diff] [review]
Proposed patch

second time lucky i guess
Comment 3 Conrad Carlen (not reading bugmail) 2003-11-10 20:03:00 PST
Comment on attachment 135199 [details] [diff] [review]
Proposed patch

r=ccarlen
Comment 4 Wan-Teh Chang 2003-11-12 18:15:26 PST
Patch checked into the NSPR tip (NSPR 4.5), NSPR_4_4_BRANCH (NSPR
4.4.1), and NSPR_PRE_4_2_CLIENT_BRANCH (Mozilla 1.6 Beta).

Note You need to log in before you can comment on or make changes to this bug.