Closed Bug 225328 Opened 21 years ago Closed 21 years ago

<toolbar.xml> code cleanup

Categories

(SeaMonkey :: General, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: sgautherie, Assigned: sgautherie)

Details

Attachments

(3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030

The purpose of this bug is not to fix a specific misbehaviour,
it's only to review patch(s) to improve the code somewhat.


Reproducible: Always

Steps to Reproduce:
Attached patch (Av1_w) Unused 'XUL_NS' removal (obsolete) — Splinter Review
(This 'diff -w' patch is to help review, not for check in.)
Attached patch (Av1) Unused 'XUL_NS' removal (obsolete) — Splinter Review
(patch coming from bug 195241 attachment 135198 [details] [diff] [review])

*Removes unused 'XUL_NS'.
*Adds a comment on empty 'catch' block.
*Adds parenthesis in 2 '() ? :' lines, to ease reading.
*(white space trimming)
Comment on attachment 135253 [details] [diff] [review]
(Av1) Unused 'XUL_NS' removal


Use attachment 135252 [details] [diff] [review] to ease review.
Attachment #135253 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #135253 - Attachment is obsolete: true
Attachment #135253 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #135252 - Attachment is obsolete: true
Attachment #136752 - Flags: review?(neil.parkwaycc.co.uk)
Assignee: general → gautheri
Severity: enhancement → trivial
OS: Windows 98 → All
Hardware: PC → All
Status: NEW → ASSIGNED
Attachment #135252 - Attachment description: (Part A) Unused 'XUL_NS' removal (v1w) → (Av1_w) Unused 'XUL_NS' removal
Attachment #135253 - Attachment description: (Part A) Unused 'XUL_NS' removal (v1) → (Av1) Unused 'XUL_NS' removal
Attachment #136752 - Attachment description: (Part A) Unused 'XUL_NS' removal v2 → (Av2) Unused 'XUL_NS' removal
Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]

>-
You didn't really mean to delete this, did you?
Attachment #136752 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #136752 - Flags: superreview?(alecf)
Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]

sr=alecf
Attachment #136752 - Flags: superreview?(alecf) → superreview+
Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]


'approval1.6=?': Trivial unused code removal.
(if not too late)
Attachment #136752 - Flags: approval1.6?
Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]

this should go into the trunk for 1.7
Attachment #136752 - Flags: approval1.6? → approval1.6-
Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]


Checked in by { 1.29	neil%parkwaycc.co.uk	Dec 20 09:52 }
Attachment #136752 - Attachment description: (Av2) Unused 'XUL_NS' removal → (Av2) Unused 'XUL_NS' removal [Checked in: Comment 9]
Attachment #136752 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7alpha
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: