225353 - Preferences -> Advanced -> Keyboard Navigation -> Find As You Type: options are swapped

Status: RESOLVED WORKSFORME

(SeaMonkey :: Find In Page, defect)

Description

[Wild Willy Kredentser]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4; en-US; rv:1.6a) Gecko/20031103
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4; en-US; rv:1.6a) Gecko/20031103

The two options work fine, but when you enable "Any text in the page" you get
"Links only" behavior, and vice versa.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Wild Willy Kredentser]

Setting operating system to OS/2..  That option is not available in the Create
Bug process.

Comment 2

[Christian Hamacher]

Confirming on reasonably recent Linux CVS trunk build: 
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6a) Gecko/20031029

It seems like this problem exists for some time - I have seen 'find as you type'
only finding links for some time, but since I never use 'only links', I never
realized the behavior is simply switched.

OS->All?

Comment 3

[timeless]

yes, i noticed this when i was fixing some other bug. 

Comment 4

[timeless]

Attachment: switch the pref labels instead of the pref meaning

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 135276 [details] [diff] [review]
switch the pref labels instead of the pref meaning

>-      <radio value="0" label="&findAsYouTypeAutoText.label;" 
>+      <radio value="1" label="&findAsYouTypeAutoText.label;" 
>              accesskey="&findAsYouTypeAutoText.accesskey;"/>
>-      <radio value="1" label="&findAsYouTypeAutoLinks.label;" 
>+      <radio value="0" label="&findAsYouTypeAutoLinks.label;" 


I think we should keep the 0,1 ordering of the radios and fix the JS instead. 
It should be a 2 line fix as well.

Comment 6

[[e-mail]]

Um... this works for me...

Rant: ideally we would use
<radiogroup id="findAsYouTypeAutoWhat" class="indent" preftype="bool"
            pref="accessibility.typeaheadfind.linksonly">
  <radio value="false" label="&findAsYouTypeAutoText.label;" 
         accesskey="&findAsYouTypeAutoText.accesskey;"/>
  <radio value="true" label="&findAsYouTypeAutoLinks.label;" 
         accesskey="&findAsYouTypeAutoLinks.accesskey;"/>
</radiogroup>
but we can't because we have a non-standard pref elsewhere on the page :-(

Comment 7

[timeless]

*** Bug 219124 has been marked as a duplicate of this bug. ***

Comment 8

[Ashley Bischoff (blog at handcoding.com)]

Confirming and marking NEW - 2003102804 on WinXP.

Comment 9

[Jord van der Elst]

Adding myself to the CC list. It's still present in Mozilla/5.0 (Windows; U;
Windows NT 5.0; en-US; rv:1.6b) Gecko/20031118

Comment 10

[Wild Willy Kredentser]

I haven't tried a nightly in a while so I got this one:

Mozilla/5.0 (OS/2; U; Warp 4; en-US; rv:1.6b) Gecko/20031205

I believe this Bug has been fixed but I'm not sure.  Unfortunately, due to Bug
225472, I have dropped back to 1.6 Alpha., which is why I can't be 100% certain.
 But I believe I did see this was fixed.  When I get a newer build that I can
run continuously, I'll confirm (or not) this comment.

Comment 11

[Arkady Sherman]

WFM in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031129

Comment 12

[Asa Dotzler [:asa]]

This bug worksforme with Windows Seamonkey builds 2004020909

Comment 13

[[e-mail]]

Comment on attachment 135276 [details] [diff] [review]
switch the pref labels instead of the pref meaning

This was fixed in bug 226549.