Closed Bug 225398 Opened 19 years ago Closed 19 years ago

res/html directory and its content not created by firebird installer

Categories

(Firefox :: Installer, defect)

x86
Windows 98
defect
Not set
minor

Tracking

()

VERIFIED FIXED

People

(Reporter: timothy.ty.lee, Assigned: sipaq)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031111 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031111 Firebird/0.7+

When browsing local file system using a FirebirdSetup.exe installed Firebird,
the images normally shown in front of files and directories are replaced by the
text "File:" and "Directory:" instead.

Reproducible: Always

Steps to Reproduce:
1.  Run FirebirdSetup.exe to install Firebird.
2.  Open the URL file:///c:/
Actual Results:  
The directory list prepend "Directory: " to directory names and "File: " to file
names.

Expected Results:  
The directory list should show a folder icon in front of a directory, and a file
icon in front of a file.

Using "Page->View Source" to look at the HTML file for the directory listing, I
can see <img> tags pointing to "resource://gre/res/html/gopher-menu.gif" and
"resource://gre/res/html/gopher-unknown.gif".  They were no where to be found
inside the Firebird installation.

Unzipping the MozillaFirebird-win32.zip package from trunk, it has been found
that the "res/html" directory and GIF files inside it were not installed by
FirebirdSetup.exe.

Manually creating the "res/html" directory and placing the GIF files under it
corrected the problem.
Confirming, based on the fact that

http://lxr.mozilla.org/mozilla/source/browser/installer/windows/packages-static

does not have the bin\res\html folder specified anywhere, and that my Firebird
install exhibits this behaviour when I rename that folder.

Also moving --> minor. This really doesn't affect functionality.
Severity: major → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch simple patchSplinter Review
This patch adds all the files under res\html
Comment on attachment 135308 [details] [diff] [review]
simple patch

Ben, can you please review this simple patch for the installer?
Attachment #135308 - Flags: review?(bugs)
Comment on attachment 135308 [details] [diff] [review]
simple patch

r=ben@mozilla.org. I didn't realize these were used.
Attachment #135308 - Flags: review?(bugs) → review+
Taking.
Assignee: bugs → bugzilla
Status: NEW → ASSIGNED
Checking in browser/installer/windows/packages-static;
/cvsroot/mozilla/browser/installer/windows/packages-static,v  <--  packages-static
new revision: 1.9; previous revision: 1.8
done
Tree is green.
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Blocks: 225724
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → installer
You need to log in before you can comment on or make changes to this bug.