225398 - res/html directory and its content not created by firebird installer

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Timothy Lee]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031111 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031111 Firebird/0.7+

When browsing local file system using a FirebirdSetup.exe installed Firebird,
the images normally shown in front of files and directories are replaced by the
text "File:" and "Directory:" instead.

Reproducible: Always

Steps to Reproduce:
1.  Run FirebirdSetup.exe to install Firebird.
2.  Open the URL file:///c:/
Actual Results:  
The directory list prepend "Directory: " to directory names and "File: " to file
names.

Expected Results:  
The directory list should show a folder icon in front of a directory, and a file
icon in front of a file.

Using "Page->View Source" to look at the HTML file for the directory listing, I
can see <img> tags pointing to "resource://gre/res/html/gopher-menu.gif" and
"resource://gre/res/html/gopher-unknown.gif".  They were no where to be found
inside the Firebird installation.

Unzipping the MozillaFirebird-win32.zip package from trunk, it has been found
that the "res/html" directory and GIF files inside it were not installed by
FirebirdSetup.exe.

Manually creating the "res/html" directory and placing the GIF files under it
corrected the problem.

Comment 1

[Ali Ebrahim]

Confirming, based on the fact that

http://lxr.mozilla.org/mozilla/source/browser/installer/windows/packages-static

does not have the bin\res\html folder specified anywhere, and that my Firebird
install exhibits this behaviour when I rename that folder.

Also moving --> minor. This really doesn't affect functionality.

Comment 2

[Simon Paquet [:sipaq]]

Attachment: simple patch

This patch adds all the files under res\html

Comment 3

[Simon Paquet [:sipaq]]

Comment on attachment 135308 [details] [diff] [review]
simple patch

Ben, can you please review this simple patch for the installer?

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 135308 [details] [diff] [review]
simple patch

r=[e-mail]. I didn't realize these were used.

Comment 5

[Simon Paquet [:sipaq]]

Taking.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in browser/installer/windows/packages-static;
/cvsroot/mozilla/browser/installer/windows/packages-static,v  <--  packages-static
new revision: 1.9; previous revision: 1.8
done

Comment 7

[Simon Paquet [:sipaq]]

Tree is green.
-> FIXED