225505 - Installer does not get rid of ns_temp in Temp folder when install completes

Status: RESOLVED FIXED

(Firefox :: Installer, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

I am left with a ns_temp folder in my user's Temp directory after installing a
build, containing all the install files - .xpis, etc. These take up valuable
disk space and should be removed after a successful installation.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

-ing, patch appreciated.

Comment 2

[Chris]

what happened to this bug? it still exists even today when installing latest
builds...

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050522
Firefox/1.0+ ID:2005052219

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This is likely fixed by changing FALSE to TRUE to the DirectoryRemove call in
DeInitialize.

Comment 4

[Jon Henry]

I tried making Gavin's suggested change last night with a trunk build, but no
dice. The installer created both an "ns_temp" and "ff_temp" directory in my temp
dir, and after the install completed "ff_temp" was still there. ns_temp gets
deleted regardless of whether the patch is applied.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> I tried making Gavin's suggested change last night with a trunk build, but no
> dice. The installer created both an "ns_temp" and "ff_temp" directory in my temp
> dir, and after the install completed "ff_temp" was still there.

Hmm, ns_temp should no longer be created by the installer, so if it is,
something else must be wrong.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Does anything get copied there during the install, or is it only being created?

Comment 7

[Jon Henry]

Attachment: Contents of the temp directories

This is everything that shows up during the installation. The ns_temp files get
created when the installer starts, then deleted when it terminates. Once you
select the install options and actually begin installing, the files in ff_temp
appear. They are not deleted when the installer terminates.

Comment 8

[Mike Connor [:mconnor]]

Disk is cheap these days, a few megs of leftover files aren't the biggest concern. Of course a well-reasoned patch would be appreciated, but not going to block on this since it should be addressed with the new installer that's slated to be used in Fx3

Comment 9

[Robert Strong (they/them - no direct email)]

This should be fixed by the NSIS installer and this bug should be fixed after it is made default by bug 339183

Comment 10

[Robert Strong (they/them - no direct email)]

I just verified that this is fixed on trunk by bug 326580 and it is now the default installer on trunk since bug 340864 was checked in.