225584 - Bug in Mozilla choosing "Location:" file when other calendars have been deleted.

Status: VERIFIED DUPLICATE of bug 225583

(Calendar :: General, defect)

Description

[Scott D. Brown]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007

If you add a new calendar and let Calendar choose the filename it creates names
like "CalendarDataFile1.ics", "CalendarDataFile2.ics", etc.  If you have N 
different calendars, the last one will have the name "CalendarDataFileN.ics".
If you delete a calendar other than the last (N) one, the next calendar that
is added will be assigned the same filename as the last one in the list.

Reproducible: Always

Steps to Reproduce:
1. Begin with the one default calendar "My Calendar"
3. Verify name of "Location:" file for "My Calendar" as "CalendarDataFile1.ics"
   by right click "Edit Calendar"
3. Add a calendar and call it "Test1"
4. Verify name of "Location:" file for "Test1" as "CalendarDataFile2.ics" 
   by right click "Edit Calendar"
5. Add a calendar and call it "Test2"
6. Verify name of "Location:" file for "Test2" as "CalendarDataFile3.ics" 
   by right click "Edit Calendar"
7. Delete calendar "Test1" by right click "Delete Calendar"
8. Add a calendar and call it "Test3"
9. Verify name of "Location:" file for "Test3" as "CalendarDataFile3.ics" 
   by right click "Edit Calendar" (same as "Test2" which is bad)
10. Make "Test3" the current calendar by clicking on it in "Calendars" pane
   in the upper left of the window.
11. Add a "New Event" usin File->New Event (or clicking on a day, etc.)
12. Note that the default "Calendar File" (bottom of dialog) is "Test2"
   even though "Test3" is current (a result of their filenames being the
   same).
13. Change the "Calendar File" to "Test3" instead and add the event.
14. Note that even though you changed the calendar in which to add the
    event to "Test3" it still got store in "Test2" (a result of their 
    filenames being the same).

Nature of problem: Strategy used to automatically create the local calendar
file most likely uses a simple index based on where the caledar is in the list.
If a calendar is deleted from the middle of the list, the last one and the next
new one will have the same filename.  Problem can be fixed by simply checking
if the generated filename already exists and incrementing the index if it does.


Actual Results:  
Any events added to the "Test2" calendar will be added to the "Test2" since they
have the same filename.

More importantly, if you notice that things are busted (without knowing the
nature of the problem) and delete "Test3" you end up deleting everything in
"Test2" instead.  This is very bad when you delete one calendar and the result
is deleting another one.

Expected Results:  
New calendars should be created by letting Mozilla automatically choose the
"Location:" of the file and the filenames should not collide with existing
files. In summary: Any new calendar should get a unique filename.

Comment 1

[Mostafa Hosseini]

*** This bug has been marked as a duplicate of 225583 ***

Comment 2

[R.J. Keller]

VERIFIED, helping brant with QA since he's been busy recently.