225644 - hook up DOMi's preferences in Firefox

Status: RESOLVED INCOMPLETE

(Other Applications :: DOM Inspector, defect)

Description

[alanjstr]

The DOMI configuration should show up as a menu item under the extensions group
in Firebird's options panel.  The Tools menu should match

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is there any documentation on how one makes things "show up as a menu item under
the extensions group in Firebird's options panel"?

Comment 2

[timeless]

since ben landed this, it's his.

Comment 3

[Chris Neale]

Attachment: provides a dialog box which mimics the environment that pref-inspector.xul expects

some overlap with attachment 137378 [details] [diff] [review] on bug 225643

Comment 4

[alanjstr]

Bug 228474 (DOMI Sidebar) is related.

Comment 5

[Chris Neale]

Attachment: proposed patch; encompasses attachment 137411 and attachment 137378

join patches together - overlap in jar.mn only

Comment 6

[Chris Neale]

patch doesn't apply cleanly since it's a mixture of cvs diff and diff /dev/null
<file>

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Mass reassign of my non-Firefox bugs to [e-mail]

Comment 8

[Steffen Wilberg]

*** Bug 233739 has been marked as a duplicate of this bug. ***

Comment 9

[Steffen Wilberg]

Comment on attachment 137618 [details] [diff] [review]
proposed patch; encompasses attachment 137411 [details] [diff] [review] and attachment 137378 [details] [diff] [review]

This is obsolete since popupOverlay.xul, toolboxOverlay.xul and inspector.xul
were forked by bug 241079.
By the way, if you want to create a patch for a new file, use "cvsdo add
filename" from cvsutils, then "cvs diff -uN filename".

Comment 10

[Steffen Wilberg]

Comment on attachment 137411 [details] [diff] [review]
provides a dialog box which mimics the environment that pref-inspector.xul expects

Removing review request from obsolete patch.

Comment 11

[Steffen Wilberg]

Comment on attachment 137411 [details] [diff] [review]
provides a dialog box which mimics the environment that pref-inspector.xul expects

> Since Steffen keeps unreviewing my prematurely obsoleted patches...
Note that contents.rdf.in is gone and the changes to jar.mn have already been
made. So this patch is obsolete indeed.

Comment 12

[Chris Neale]

contents.rdf.in has gone, fine.
but, contents.rdf doesn't have basic Fx extension pieces ...

there will be one jar.mn change to add, since this adds another file.


should a new patch add the settings file to install.rdf for DOM Inspector ?

Comment 13

[alanjstr]

Are the preferences still accessible?  

Comment 14

[Christopher Aillon (sabbatical, not receiving bugmail)]

Um, this should definitely NOT change for GNOME.  Firefox already gets this
right.  There may be other platforms as well where that is the case.  Don't make
me hunt you down!

Comment 15

[alanjstr]

We probably have a standard #ifdef for choosing the correct prefs location.

Comment 16

[Samuel Sidler (old account; do not CC)]

Is this bug still valid?

Comment 17

[Steffen Wilberg]

As I understand it, this bug is about hooking up DOMi's preferences dialog in Firefox, which is not accessible right now. The proper location would be Tools->Extensions->DOM Inspector context menu->Options.

Firefox still ships this dialog (it doesn't work though): chrome://inspector/content/prefs/pref-inspector.xul.

From looking at it, this dialog is pretty unnecessary.

Comment 18

[Alex Vincent [:WeirdAl]]

(In reply to comment #17)
> Firefox still ships this dialog (it doesn't work though):
> chrome://inspector/content/prefs/pref-inspector.xul.
> 
> From looking at it, this dialog is pretty unnecessary.

SeaMonkey uses that panel in its older-style preferences.  Remove that at your own peril.

Comment 19

[Shawn Wilsher :sdwilsh]

(In reply to comment #17)
> As I understand it, this bug is about hooking up DOMi's preferences dialog in
> Firefox, which is not accessible right now. The proper location would be
> Tools->Extensions->DOM Inspector context menu->Options.
> 
> Firefox still ships this dialog (it doesn't work though):
> chrome://inspector/content/prefs/pref-inspector.xul.
> 
> From looking at it, this dialog is pretty unnecessary.

Bug 175199 asks to remove it from Firefox.  Does anybody know if this is still used in SeaMonkey, or is it safe to remove?

Comment 20

[alanjstr]

DOMI has become a Firefox extension, so think this bug is moot.

Comment 21

[Shawn Wilsher :sdwilsh]

er, it's not moot.  We can in fact still use the preferences in Firefox.

Comment 22

[Firefox Bug Husbandry Bot]

Bulk close. This component is no longer supported or maintained.

https://bugzilla.mozilla.org/show_bug.cgi?id=1499023

Comment 23

[Firefox Bug Husbandry Bot]

Bulk close. This component is no longer supported or maintained.

https://bugzilla.mozilla.org/show_bug.cgi?id=1499023