225826 - We request a new nsIObserverService for every window opened

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: APIs, defect, P3)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

nsWindowWatcher::AddWindow() is the culprit.

/me has a fix.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Cache the observer service on the window watcher

and use it, too!

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 135595 [details] [diff] [review]
Cache the observer service on the window watcher

- In nsWindowWatcher.h:

+class	nsIObserverService;
...
+  nsCOMPtr<nsIObserverService> mObserverService;

Is a forward declaration enough when using nsCOMPtr's now? Don't you need to
#include nsIObserverService.h for this to work on all platforms?

sr=jst

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Johnny, the ability to forward declare was re-introduced this summer (bug
107291) so it should be enough.

Comment 4

[Johnny Stenback (:jst)]

Oh, awesome! I didn't see that change go by...

Comment 5

[Dan M]

'scool. While you're in there, why not replace the "include nsIWindowCreator.h"
line with a forward declaration, too. It compiles. nsWindowCreator.h is included
by only two files and them that needs nsIWindowCreator already include it
separately.

One more worry, though. What about the pseudo-leak caused by two services
strong-refing each other? Sometimes we worry about that and sometimes we don't.
Maybe you guys know the most current dogma.

Comment 6

[Dan M]

Actually this one isn't circular, it's just one service refing another. Still a
potential problem, though. I'm dogma curious.

Comment 7

[Hixie (not reading bugmail)]

Is this patch still relevant? It has sr but is waiting r from danm?

Comment 8

[Dan M]

waiting for an answer to the question posed in comment 5

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Probably should add an observer for xpcom shutdown then.  But after thinking
about it, this probably doesn't gain us too much, so marking wontfix.