DRefTool analysis for universalchardet files

RESOLVED FIXED

Status

()

Core
Internationalization
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Comment 1

14 years ago
void nsUniversalDetector::HandleData(const char* aBuf, PRUint32 aLen)

What should i do when it fails?
Status: NEW → ASSIGNED
(Assignee)

Comment 2

14 years ago
Created attachment 144646 [details] [diff] [review]
make handledata return rv's. -uwp
(Assignee)

Updated

14 years ago
Attachment #144646 - Flags: review?(smontagu)
Comment on attachment 144646 [details] [diff] [review]
make handledata return rv's. -uwp

do you want to fix this call site too?
http://lxr.mozilla.org/seamonkey/source/extensions/universalchardet/src/nsUnive
rsalDetector.cpp#383
(Assignee)

Updated

14 years ago
Attachment #144646 - Flags: review?(smontagu)
(Assignee)

Comment 4

14 years ago
Created attachment 146662 [details] [diff] [review]
make handledata return rv's -uwp, and propagate them
Attachment #144646 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #146662 - Flags: review?(smontagu)
Comment on attachment 146662 [details] [diff] [review]
make handledata return rv's -uwp, and propagate them

>@@ -203,8 +203,11 @@ void nsUniversalDetector::HandleData(con
>   switch (mInputState)
>   {
>   case eEscAscii:
>-    if (nsnull == mEscCharSetProber)
>+    if (nsnull == mEscCharSetProber) {
>       mEscCharSetProber = new nsEscCharSetProber;
>+      if (!mEscCharSetProber)
>+        return NS_ERROR_OUT_OF_MEMORY;

Nit: change |if (!mEscCharSetProber)| to if (nsnull == mEscCharSetProber)| (or
vice versa, I suppose)

r=smontagu.
Attachment #146662 - Flags: review?(smontagu) → review+
(Assignee)

Updated

14 years ago
Attachment #146662 - Flags: superreview?(roc)
Attachment #146662 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 6

14 years ago
mozilla/extensions/universalchardet/src/nsUniversalDetector.cpp 	1.18
mozilla/extensions/universalchardet/src/nsUniversalDetector.h 	1.9
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.