225994 - DRefTool analysis for universalchardet files

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[timeless]

Bugs:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/universalchardet/src/nsUniversalDetector.cpp&rev=1.16&mark=209#204
Deref-error: "mEscCharSetProber"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/universalchardet/src/nsUniversalDetector.cpp&rev=1.16&mark=213#208
Deref-error: "mEscCharSetProber"

Comment 1

[timeless]

void nsUniversalDetector::HandleData(const char* aBuf, PRUint32 aLen)

What should i do when it fails?

Comment 2

[timeless]

Attachment: make handledata return rv's. -uwp

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 144646 [details] [diff] [review]
make handledata return rv's. -uwp

do you want to fix this call site too?
http://lxr.mozilla.org/seamonkey/source/extensions/universalchardet/src/nsUnive
rsalDetector.cpp#383

Comment 4

[timeless]

Attachment: make handledata return rv's -uwp, and propagate them

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 146662 [details] [diff] [review]
make handledata return rv's -uwp, and propagate them

>@@ -203,8 +203,11 @@ void nsUniversalDetector::HandleData(con
>   switch (mInputState)
>   {
>   case eEscAscii:
>-    if (nsnull == mEscCharSetProber)
>+    if (nsnull == mEscCharSetProber) {
>       mEscCharSetProber = new nsEscCharSetProber;
>+      if (!mEscCharSetProber)
>+        return NS_ERROR_OUT_OF_MEMORY;

Nit: change |if (!mEscCharSetProber)| to if (nsnull == mEscCharSetProber)| (or
vice versa, I suppose)

r=smontagu.

Comment 6

[timeless]

mozilla/extensions/universalchardet/src/nsUniversalDetector.cpp 	1.18
mozilla/extensions/universalchardet/src/nsUniversalDetector.h 	1.9