226019 - DRefTool analysis for xpconnect files

Status: RESOLVED WORKSFORME

(Core :: XPConnect, defect)

Description

[timeless]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/XPCDispObject.cpp&rev=1.11&mark=341#336
Deref-error: "params"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/XPCDispObject.cpp&rev=1.11&mark=342#337
Deref-error: "params"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/XPCDispObject.cpp&rev=1.11&mark=367#362
Deref-error: "params"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/XPCDispObject.cpp&rev=1.11&mark=367#362
Deref-error: "params"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/XPCDispObject.cpp&rev=1.11&mark=369#364
Deref-error: "params"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/XPCDispObject.cpp&rev=1.11&mark=377#372
Deref-error: "params"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/XPCDispObject.cpp&rev=1.11&mark=377#372
Deref-error: "params"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/xpcconvert.cpp&rev=1.83&mark=1400#1395
Deref-error: "data"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/src/xpcstring.cpp&rev=1.17&mark=104#99
Deref-error: "sBufferHandle"

Comment 1

[timeless]

Attachment: handle alloc failure

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 135762 [details] [diff] [review]
handle alloc failure

Wow, we allocate memory on every XPCInvoke? That sounds terrible!

Comment 3

[John Bandhauer]

>Wow, we allocate memory on every XPCInvoke? That sounds terrible!

No. One case was an MS COM call. One was one sort of string conversion. The
other was an exception conversion. All unusual cases.

Comment 4

[Andrew McCreight [:mccr8]]

Allocation is mostly infallible now.