This is needed for mod_perl. There's an XXX - mod_perl comment on our existing Cookie code which describes this. Patch coming momentarily.
Comment on attachment 135767 [details] [diff] [review] Patch This fixes the situation by stashing the cookies (as the comment indicates it should have been) instead of printing them, and then overriding the CGI->header() method to add the cookie parameter containing our cookie list before calling the real CGI->header.
Comment on attachment 135767 [details] [diff] [review] Patch After further testing, this is broken. Replacement patch coming up shortly
If we're storing a Content-Type in it, is Bugzilla_cookie_list still an appropriate name?
We store nothing but cookies in Bugzilla_cookie_list. The content-type is being passed in, not being read from Bugzilla_cookie_list.
Created attachment 136093 [details] [diff] [review] Patch v3 Oops, cookies didn't work in buglist.cgi. Fixed that with this rev.
Attachment #135775 - Attachment is obsolete: true
Attachment #136093 - Flags: review?(bbaetz)
Comment on attachment 136093 [details] [diff] [review] Patch v3 I guess. How about fixing multipart_start via an upstream patch? r=bbaetz anyway - given the limited requirements we have for multipart_start, this is OK
Attachment #136093 - Flags: review?(bbaetz) → review+
Checking in Bugzilla/CGI.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v <-- CGI.pm new revision: 1.7; previous revision: 1.6 done
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
You need to log in before you can comment on or make changes to this bug.