226027 - Make Bugzilla use CGI.pm to send Cookie headers

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Dave Miller [:justdave]]

This is needed for mod_perl.  There's an XXX - mod_perl comment on our existing
Cookie code which describes this.  Patch coming momentarily.

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 135767 [details] [diff] [review]
Patch

This fixes the situation by stashing the cookies (as the comment indicates it
should have been) instead of printing them, and then overriding the
CGI->header() method to add the cookie parameter containing our cookie list
before calling the real CGI->header.

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 135767 [details] [diff] [review]
Patch

After further testing, this is broken.	Replacement patch coming up shortly

Comment 4

[Dave Miller [:justdave]]

Attachment: Patch v2

Previous iteration didn't take into account that the caller might have passed a
non-qualified content-type as a parameter (like the new js buglist which does
$cgi->header("text/javascript"); ).  This one fixes that and also only adds the
Cookie part if there's cookies to add, instead of passing an empty array of
cookies.

Comment 5

[Christian Reis]

If we're storing a Content-Type in it, is Bugzilla_cookie_list still an
appropriate name?

Comment 6

[Dave Miller [:justdave]]

We store nothing but cookies in Bugzilla_cookie_list.  The content-type is being
passed in, not being read from Bugzilla_cookie_list.

Comment 7

[Dave Miller [:justdave]]

Attachment: Patch v3

Oops, cookies didn't work in buglist.cgi.  Fixed that with this rev.

Comment 8

[Bradley Baetz (:bbaetz)]

Comment on attachment 136093 [details] [diff] [review]
Patch v3

I guess. How about fixing multipart_start via an upstream patch?

r=bbaetz anyway - given the limited requirements we have for multipart_start,
this is OK

Comment 9

[Dave Miller [:justdave]]

Checking in Bugzilla/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v  <--  CGI.pm
new revision: 1.7; previous revision: 1.6
done