Option "for the originating Web site only" loses selection if "Load Images" is not selected

RESOLVED WONTFIX

Status

()

Firefox
Preferences
P4
minor
RESOLVED WONTFIX
15 years ago
12 years ago

People

(Reporter: Martynas, Assigned: mconnor)

Tracking

({polish})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031116 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031116 Firebird/0.7+

If option "for the originating Web site only" (Web Features) is selected and
"Load Images" is deselected then option "for the originating Web site only"
looses selection after Options UI is closed and opened again.


Reproducible: Always

Steps to Reproduce:
1. Select options "Load Images" (Web Features), "for the originating Web site
only" (Web Features)
2. Deselect option "Load Images"
3. Close Option UI
4. Open Option UI

Actual Results:  
Option "for the originating Web site only" (Web Features) lost selection

Expected Results:  
Option "for the originating Web site only" (Web Features) ought to stay selected.
(Assignee)

Comment 1

15 years ago
-> me

due to the pref in questin being an integer.  patch upcoming
Assignee: blake → mpconnor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
Target Milestone: --- → Firebird0.8
(Assignee)

Comment 2

15 years ago
Created attachment 135863 [details] [diff] [review]
add a persist to the secondary checkbox
(Assignee)

Comment 3

15 years ago
Comment on attachment 135863 [details] [diff] [review]
add a persist to the secondary checkbox

little one-liner for polish
Attachment #135863 - Flags: review?(bugs)

Comment 4

15 years ago
Comment on attachment 135863 [details] [diff] [review]
add a persist to the secondary checkbox

there shouldn't be a need to use a persist attribute.
Look at how cookies are implemented.
Attachment #135863 - Flags: review?(bugs) → review-
(Assignee)

Comment 5

15 years ago
actually, unchecking Enable Cookies instantly unchecks the other options for
Cookies, so I don't think that's a good example...

the point is to be able to disable images and then re-enable them without
checking the box again (if you're going from none at all to for originating
only, which is the next incremental step).  If you can suggest a way to persist
the state of the checkbox besides a pref, that would be quite welcomee.
(Assignee)

Comment 6

15 years ago
Comment on attachment 135863 [details] [diff] [review]
add a persist to the secondary checkbox

consistency issue:
cookies UI unchecks all three sub-checkboxes, find as you type always persists
(since its a separate pref) and this only loses the checkbox once the user hits
OK on the Options dialog.

per much earlier discussion with pch, moving review request to ben based on
this

ben: should we persist sub-prefs or not?  personally I feel that having to
recheck the box here is an annoyance to most users.  If you disagree, we can
always force this unchecked when the parent is unchecked to remain consistent,
but I feel like that's just a step in the wrong direction
Attachment #135863 - Flags: review- → review?(bugs)

Comment 7

15 years ago
Comment on attachment 135863 [details] [diff] [review]
add a persist to the secondary checkbox

this patch is not robust: if the user changes the pref via about:config or
editing manually the pref file, the checkbox will be persisted and not in sync
with the actual pref.
Attachment #135863 - Flags: review?(bugs) → review-
-> 0.9
Target Milestone: Firebird0.8 → Firebird0.9

Updated

14 years ago
Summary: Option "for the originating Web site only" looses selection if "Load Images" is not selected → Option "for the originating Web site only" loses selection if "Load Images" is not selected
(Assignee)

Comment 9

14 years ago
this is a little quirk to deal with, should we go as far as to use a pref on this?
Status: NEW → ASSIGNED
Priority: -- → P4
(Assignee)

Comment 10

14 years ago
will look at this again after the prefpanel changes that are coming for 0.9
Target Milestone: Firefox0.9 → Firefox1.0beta
(Assignee)

Comment 11

13 years ago
This should really just be removed, see bug 287571
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → WONTFIX
Target Milestone: Firefox1.0beta → ---
(Assignee)

Comment 12

12 years ago
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.