Internal Server Error while requesting an attachment flag

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Attachments & Requests
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: Christian Reis, Assigned: Christian Reis)

Tracking

({regression})

2.17.6
Bugzilla 2.18
regression
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

15 years ago
On CVS HEAD, requesting a flag raises an ISE 500. Problem seems to be a bare
Param() in FlagType.pm, patch coming up.

Question: does the following case in User.pm suffer from the same problem?

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/webtools/bugzilla/Bugzilla&command=DIFF_FRAMESET&file=User.pm&rev2=1.15&rev1=1.14
(Assignee)

Comment 1

15 years ago
Created attachment 135917 [details] [diff] [review]
kiko_v1: use &::Param
(Assignee)

Updated

15 years ago
Attachment #135917 - Flags: review?(myk)

Updated

15 years ago
OS: Linux → All
Hardware: PC → All
(Assignee)

Comment 2

15 years ago
Created attachment 135922 [details] [diff] [review]
kiko_v2: use Bugzilla::Config

Hixie explained the details on how namespaces and use work, and I guess the
better fix is this one-liner.

Should we clean up other uses of &::Param() ?
(Assignee)

Updated

15 years ago
Attachment #135917 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #135917 - Flags: review?(myk)
(Assignee)

Updated

15 years ago
Attachment #135922 - Flags: review?(myk)
I'm having difficulty reproducing the problem; can you give more specifics about
when it occurs (i.e. requestable or non-requestable flag, attachment or bug, etc.).
(Assignee)

Comment 4

15 years ago
It occured in landfill, on caillon's branch (for the xmlflags thing), for
reference -- the log will say. It happens when requesting any attachment flag
when a requestee is specified. I think requesting with no requestee works.

Isn't the code obviously wrong, at any rate? We don't use Bugzilla::Config, so
Param is never placed in our local namespace.

Status: NEW → ASSIGNED
Summary: Internal Server Error while requesting a flag → Internal Server Error while requesting an attachment flag
Comment on attachment 135922 [details] [diff] [review]
kiko_v2: use Bugzilla::Config

r=myk

Yes, we should fix other instances of &::Param in that script now that it's no
longer necessary.
Attachment #135922 - Flags: review?(myk) → review+
Flags: approval+
(Assignee)

Comment 6

15 years ago
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/FlagType.pm,v  <--  FlagType.pm
new revision: 1.5; previous revision: 1.4

Thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Summary: Internal Server Error while requesting an attachment flag
(Assignee)

Updated

15 years ago
Summary: Internal Server Error while requesting an attachment flag
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.