Closed Bug 226242 Opened 21 years ago Closed 4 years ago

HAVE_ICONV_WITH_CONST_INPUT test is not strict enough not to define it for HP/HP-UX 11

Categories

(Core :: Internationalization, enhancement)

HP
HP-UX
enhancement
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: timeless, Assigned: smontagu)

Details

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1069228920.3452.gz Error (future) 212: "nsNativeCharsetUtils.cpp", line 125 # Argument type 'const char **' does not match expected parameter type 'char **'.../../dist/bin/xpidl -m typelib -w -I ../../dist/idl -I. -o _xpidlgen/nsIBinaryInputStream nsIBinaryInputStream.idl res = iconv(converter, ICONV_INPUT(input), inputLeft, output, outputLeft); ^^^^^^^^^^^
uhm.. more context please. what build is this breaking? i don't see any red tinderboxen on MozillaTest. i suspect that you are running some special tool? that is not a compiler error message right?
It's not breaking because it's a future warning. If I controlled the box, then I could set a flag to make it break today. This is absolutely a compiler error message.
as i told timeless over irc... i believe that the autoconf test should do the right thing provided the same compiler options are given both when configure is run and when nsNativeCharsetUtils is compiled. however, if there is the possibility that different compiler flags could be used, then maybe we should enable the "picky" flag in configure. otherwise, i think there isn't much to do here.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: darin → smontagu
QA Contact: amyy → i18n

The file is gone.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.