226350 - Simultaneously deleting multiple history entries fails - error [@ nsTreeController_delete :: line 176"]

Status: RESOLVED WORKSFORME

(Core Graveyard :: History: Global, defect)

Description

[Justin Shore]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5) Gecko/20031007
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5) Gecko/20031007

This bug is pretty simple.  You can select more than one entry under "Title"
easily enough.  However ctrl-clicking and selecting Delete or pressing the
Delete key only deletes one of the selections.  For example lets say I've
visited pages on www.website1.com and www.website2.com.  I select both of those
"domains" in the History window under Title.  I then either control-click on one
of them and select delete or I press the Delete key.  Only one of the selections
is deleted.  The other is left untouched.

Reproducible: Always

Steps to Reproduce:
1. In the History window select two "domains" you've visited.
2. Attempt to delete them by either control-clicking one of them and selecting
Delete from the pop-up menu or by pressing the Delete key.

Actual Results:  
Only one of the selected "domains" is deleted.  The other(s) is left untouched.

Expected Results:  
All of the selections should have been deleted.  If Mozilla will let you select
more than on history entry (a good thing) then it should let you apply actions
to all of the selected items at once.

I haven't been able to try this on any other platforms yet.  Firebid 0.7.1
didn't seem to have this problem though.  It's worth noting that selecting more
than one "Location" under a "domain" or more and deleting them works fine.  The
problem only seems to happen when you just select domains.  It's not a big deal;
just a problem I noticed.

Comment 1

[Andreas Kunz]

Confirming on Win2k.

error in JS console:
Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsIXULTreeBuilder.getResourceAtIndex]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://global/content/nsTreeController.js :: nsTreeController_delete :: line
174"  data: no]
Source File: chrome://global/content/nsTreeController.js
Line: 174

As a note: deleting two regular items does not delete anything here, but that's
not this bug.

Comment 2

[OstGote!]

WFM Mozilla 1.7b 2004031008 WinNT4

Still a problem for others? Tried both normal entries and two "domain" entries.
No errors.

Comment 3

[Andreas Kunz]

Justin, this also works for me with 1.6 on Windows XP.
Unfortunately I did not mention the Mozilla version in my confirmation comment,
but it was before the 1.6 release...
I'll re-test on Win2k when I come to it, but you might also test it with 1.6 or
1.7a and resolve this bug if the problem does not occur anymore.

Comment 4

[Andreas Kunz]

I retested on Win2k and noticed that this bug still occurs, but only (at least
for me) when the domain entries are "opened" to show the visited pages. So not
fixed.

Comment 5

[irongut]

*** Bug 291754 has been marked as a duplicate of this bug. ***

Comment 6

[irongut]

Confirmed as comment 4 and saw error in comment 1.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050521

Firefox 1.0.4 doesn't let me select more than one bookmark and doesn't have
domain groups so doesn't show this bug.

Comment 7

[Staszek Pitucha]

I don't know if it's duplicate of Bug 291754 - that one I submited happens even
with all domain groups closed and only without column sort applied. It also
rearranged entries on a day group (nothing about that thing here).

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to comment #4)
> I retested on Win2k and noticed that this bug still occurs, but only (at least
> for me) when the domain entries are "opened" to show the visited pages. So not
> fixed.

right.
open 2 domains.
select just the two domains.
hit delete.
only one is deleted

console contents:
Error: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXULTreeBuilder.getResourceAtIndex]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://global/content/nsTreeController.js :: nsTreeController_delete :: line 176"  data: no]
Source File: chrome://global/content/nsTreeController.js
Line: 176

Comment 9

[Wayne Mery (:wsmwk)]

"show all" history is no longer lists by domain.
> invalid?