226405 - [gtk2] paste into html compose window doesn't work

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Darin Fisher]

paste into mail compose window doesn't work.  this might be specific to the
GTK2+XFT build.  i've noticed this problem in both seamonkey and thunderbird. 
there aren't any messages in the javascript console.  i'll provide more info
once i have a debug build that i can test.

Comment 1

[Darin Fisher]

i meant to add that paste works into other fields, such as the mail message
compose summary field or the address fields.  i think this is specific to the
mail message compose window.  i haven't tried regular composer.

Comment 2

[Stewart Gordon]

Menu command, keyboard shortcut, context menu, have you tried them all?  (I
assume they all exist on Linux?)

What does it do - just nothing?  Menu command greyed out or not?

Comment 3

[Darin Fisher]

i think this may have been caused by bug 214583.  it looks like this is a bug in
the nsClipboard.cpp code inside widget/src/gtk2.  wait_for_contents returns with
a non-null selectionData, but the contents of selectionData are bogus:

(gdb) p *selectionData
$8 = {selection = 0x1, target = 0x74, type = 0x0, format = 0, data = 0x0, length
= -1, display = 0x8081508}

-> bryner

Comment 4

[Brian Ryner (not reading)]

This also seems to be specific to HTML compose.  Plain text compose doesn't show
the problem for me.

Comment 5

[Darin Fisher]

Attachment: v1 patch

bryner and i came up with this today.  turns out GTK+-2.2.2 does this in its
code. we should do the same.  the patch causes selectionData to be null when we
return from wait_for_contents.	as a result, we will request the selection
flavor.

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 136076 [details] [diff] [review]
v1 patch

r/sr=bryner

Comment 7

[Darin Fisher]

here's the GTK+-2.2.2 code:

static void
clipboard_received_func (GtkClipboard     *clipboard,
             GtkSelectionData *selection_data,
             gpointer          data)
{
  WaitResults *results = data;
                                                                               
                                                                         
  if (selection_data->length >= 0)
    results->data = gtk_selection_data_copy (selection_data);
                                                                               
                                                                         
  g_main_loop_quit (results->loop);
}

here's our current version of this function:

static void
clipboard_contents_received(GtkClipboard     *clipboard,
                            GtkSelectionData *selection_data,
                            gpointer          data)
{
    GtkSelectionData **sel_copy = NS_STATIC_CAST(GtkSelectionData **, data);
    *sel_copy = gtk_selection_data_copy(selection_data);
}

the patch makes our code behave like the code from GTK+-2.2.2 :)

Comment 8

[Darin Fisher]

-> me for checkin

Comment 9

[Darin Fisher]

Comment on attachment 136076 [details] [diff] [review]
v1 patch

this would be a good patch to get in for beta.

Comment 10

[Brendan Eich [:brendan]]

Comment on attachment 136076 [details] [diff] [review]
v1 patch

a=[e-mail] and drivers for 1.6b.

/be

Comment 11

[Darin Fisher]

fixed on trunk for 1.6 beta

Comment 12

[tor]

This checkin is causing long UI pauses in my gtk2/xft build (bug 226267).
The value of selection_data->length always seems to be -1 in my limited
testing.

Comment 13

[Darin Fisher]

marking FIXED again now that bryner has a patch in bug 226267.