226583 - Request queue header is way too wide

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[timeless]

If "Request Queue" is taken out of the table, it's almost not bad. That's what
I'd like to do.

Comment 1

[timeless]

Attachment: picture of problem

Comment 2

[Max Kanat-Alexander]

Yes, I agree. :-)

Comment 3

[A. Karl Kornel]

This may be as simple as taking the big filter_form block and moving it under
the 'PROCESS global/header' block, since for some reason the big filter_form
table is being used as the h2.

Comment 4

[Teemu Mannermaa (:wicked)]

Urgh.. It sure is a great idea to use a form inside a h2 tag. That won't fly for
very long.. Both HTML 4.01 standard and validity check agrees with me:

line 86 column 5 - Warning: missing </h2> before <form>
line 161 column 8 - Warning: discarding unexpected </h2>
line 86 column 5 - Warning: trimming empty <h2>

I looked and luckily it seems request.html.tmpl is the only one abusing h2 tag
(atleast when passed to header.html.tmpl). I can fix this, unless myk is just
about to attach a patch.. :)

BTW, this change seems to have been introduced by myk in bug 179360.

Comment 5

[Teemu Mannermaa (:wicked)]

Attachment: Move filter form below h1, V1

Comment 6

[Frédéric Buclin]

Comment on attachment 193144 [details] [diff] [review]
Move filter form below h1, V1

r=LpSolit

Comment 7

[Frédéric Buclin]

The patch applies cleanly to 2.20. Makes sense to have it there too.

Comment 8

[Dave Miller [:justdave]]

yes! been waiting for this one. :)

Comment 9

[Frédéric Buclin]

tip:

Checking in template/en/default/request/queue.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl,v
 <--  queue.html.tmpl
new revision: 1.13; previous revision: 1.12
done

2.20rc2:

Checking in template/en/default/request/queue.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl,v
 <--  queue.html.tmpl
new revision: 1.12.6.1; previous revision: 1.12
done

Comment 10

[Frédéric Buclin]

*** Bug 184403 has been marked as a duplicate of this bug. ***