226612 - -remote openURL no longer works with null URL.

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Scott Gifford]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031122 Firebird/0.7+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031122 Firebird/0.7+

In earlier versions of Firebird, I could use:

    MozillaFirebird -remote 'openURL(,new-window)'

to open up a blank new window.  Now that gives an error, and starts up another
copy of Firebird.

As a work-around, I can use about:blank - 

    MozillaFirebird -remote "openURL(about:blank,new-window)"

but this change in behavior broke my toolbar link.


Reproducible: Always

Steps to Reproduce:
1.Start up MozillaFirebird
2.Run MozillaFirebird -remote "openURL(about:blank,new-window)"

Actual Results:  
An error was printed, and a new copy of FB started up.


Expected Results:  
A new blank Firebird window.


It worked with FB0.6, and doesn't work with 20031122.  I didn't notice it was
broken until this last week, so it probably broke in a recent build.

Comment 1

[David Baron :dbaron:]

->darin

Comment 2

[David Baron :dbaron:]

Since darin says it's easy to fix, I want this bug to cover
openURL(/tmp/foo,new-window) as well.  (It should accept files without "file://"
at the beginning.)

Comment 3

[Darin Fisher]

Attachment: v1 patch

simple patch.  check for empty aURL, and allow that.  if loading aURL as a URI
fails, then try creating a nsILocalFile from it.  NOTE: nsLocalFile takes care
of paths starting with "~/" and not just "/", which is good in this case.

Comment 4

[Darin Fisher]

Attachment: v1.1 patch

thanks to dbaron for catching my mistake in the previous patch.  that would
have caused thunderbird to try to load file:// URLs! :-(

this patch solves that problem by reworking things so that we always call
IsExposedProtocol.

Comment 5

[David Baron :dbaron:]

Comment on attachment 136345 [details] [diff] [review]
v1.1 patch

This fixes the problems I was seeing and looks good to me, although I'm not
sure if you want the unconditional return true on empty -- maybe it should be
treated as about: because thunderbird might not want to handle the about
protocol, i.e.,

if (aURL.IsEmpty())
  scheme = "about"; // ':' needed??
else
  iso->ExtractScheme(aURL, scheme);
...

Comment 6

[Darin Fisher]

Attachment: v1.2 patch

thanks again dbaron!

Comment 7

[David Baron :dbaron:]

Don't forget to land this. :-)

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 136352 [details] [diff] [review]
v1.2 patch

a=[e-mail] for 1.6b.

/be

Comment 9

[Darin Fisher]

fixed-on-trunk for 1.6 beta

Comment 10

[Scott Gifford]

This appears fixed in FB 20031130.  Thanks for the fast work!

Comment 11

[Scott Gifford]

I'm seeing pretty much this same bug again, although now instead of opening up a
new window when I run:

    MozillaFirebird -remote 'openURL(,new-window)'

it just displays an error:

    Failed to send command.

As before, using:

    MozillaFirebird -remote "openURL(about:blank,new-window)"

works just fine.

Comment 12

[Scott Gifford]

This is in FB 20040114, trunk.

Comment 13

[Scott Gifford]

Looks like this is fixed in FB 20040119.  Changing back to fixed.