PAC: cannot specify SOCKS5 proxy

VERIFIED FIXED in mozilla1.6beta

Status

()

--
critical
VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: darin.moz, Assigned: darin.moz)

Tracking

Trunk
mozilla1.6beta
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

15 years ago
The 8tre wrote:

>Hi all,
>
>I'm using Firebird 0.7 on windows.
>I'm using a proxy.pac file containing SOCKS4 and SOCKS5 proxies.
>Something like :
>function FindProxyForURL(url, host)
>{
>   return "SOCKS5 14.147.6.155:3560; SOCKS4 258.165.349.12:2412";
>}
>
>Firebird has no problem using proxies specified as SOCKS4 but when I
>the first proxy in the list is a SOCKS5 one a dialog box shows up
>asking to install PSM.
>
>I found a PSM test page on the web telling me that my PSM version is
>2.4 and that the manager is currently running.
>
>It would be nice if one of you could give some hints on this Problem.
>
>Thanks in advance,
>--
>The 8tre
>

there is code to support SOCKS5, but it appears to be broken.  it looks like we
need to map the PAC result string "SOCKS5" to a necko socket type of just plain
"socks".  currently, we map it to "socks5" which is not registered as a socket type.
(Assignee)

Updated

15 years ago
Severity: normal → critical
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.6beta
(Assignee)

Comment 1

15 years ago
Created attachment 136261 [details] [diff] [review]
v1 patch

this patch should do the trick.  i still need to verify it though.
(Assignee)

Comment 2

15 years ago
Created attachment 137280 [details] [diff] [review]
v1.1 patch

v1 patch works.  this patch fixes a two warnings.
Attachment #136261 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #137280 - Flags: review?(dougt)

Updated

15 years ago
Attachment #137280 - Flags: review?(dougt) → review+
(Assignee)

Comment 3

15 years ago
Comment on attachment 137280 [details] [diff] [review]
v1.1 patch

bz: i think this patch is a good candidate for 1.6 final.
Attachment #137280 - Flags: superreview?(bz-vacation)
Comment on attachment 137280 [details] [diff] [review]
v1.1 patch

sr=bzbarsky.  Does that make kProxyType_SOCKS5 unused?	If so, can we kill it
off?
Attachment #137280 - Flags: superreview?(bz-vacation) → superreview+
(Assignee)

Comment 5

15 years ago
bz: nope, kProxyType_SOCKS5 is still used.  it is used in ExtractProxyInfo.
(Assignee)

Comment 6

15 years ago
Comment on attachment 137280 [details] [diff] [review]
v1.1 patch

i tested this patch against a Dante SOCKS5 proxy w/ a custom PAC file to verify
that i was able to direct mozilla to use my SOCKS5 proxy.

i think this is a safe and good patch for 1.6.
Attachment #137280 - Flags: approval1.6?

Comment 7

15 years ago
Comment on attachment 137280 [details] [diff] [review]
v1.1 patch

a=tor for 1.6 checkin.
Attachment #137280 - Flags: approval1.6? → approval1.6+

Comment 8

15 years ago
Has this been landed yet? It's going to need to get in quickly if it's going to
make the 1.6 branch.
(Assignee)

Comment 9

15 years ago
fixed-on-trunk for 1.6 final
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 10

15 years ago
VERIFIED per Darin's comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.