226673 - "xxx::yyy" used only once error

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Gervase Markham [:gerv]]

I just updated and ran checksetup.pl and got:

Name "PatchReader::Version" used only once: possible typo at ./checksetup.pl
line 192.

This is 100% repeatable.

Gerv

Comment 1

[Jouni Heikniemi]

This is not Patchreader specific, but is shown for all missing modules. This is
a regression caused by bug 208604. It's got something to do with adding that
BEGIN block into checksetup. 

Ccing some posse involved. Dave, Bradley: Ideas?

Comment 2

[Dave Miller [:justdave]]

OK, localizing $::SIG{__DIE__} doesn't work either.  CGI::Carp's die override
stays in place if checksetup dies later, so we still get all the "Software
Error" HTML wrapper around the error messages, too.

Comment 3

[Bradley Baetz (:bbaetz)]

Hey, perl's smarter than I thought....

That code looks a bit silly (ie instead of the .pm appending, just eval "require
$pkg" should do it for us.

Module::Build doesn't do a require; it looks through @INC and then gresp the
file for a VERSION line, and then evals that. I don't think we want to duplicate
that code in checksetup.pl....

|local $^W| should do it arround that block, I guess.

Comment 4

[Dave Miller [:justdave]]

Attachment: Patch

This fixes the "used only once" error.

It does not fix the $::SIG{__DIE__} override problem.

Comment 5

[Dave Miller [:justdave]]

ok, think I got this figured out.  -> me

Comment 6

[Dave Miller [:justdave]]

Attachment: Patch v2

OK, this fixes both problems.

The $::SIG{__DIE__} problem wound up being unrelated, though that's also a
regression....	so I went ahead and fixed it here as long as we were discussing
it.

What happened with the die thing is checksetup.pl does a "require globals.pl"
which does a "use RelationSet" which does a "use CGI::Carp".  Couldn't find any
reason RelationSet actually needs that, so I just removed that line from
RelationSet.

Comment 7

[Christian Reis]

bug 226892 will allow us to remove the globals.pl requirement from checksetup.pl

Comment 8

[Dave Miller [:justdave]]

Checking in RelationSet.pm;
/cvsroot/mozilla/webtools/bugzilla/RelationSet.pm,v  <--  RelationSet.pm
new revision: 1.9; previous revision: 1.8
done
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.254; previous revision: 1.253
done