The default bug view has changed. See this FAQ.

The WINNT version of PR_Accept leaks a socket handle if it fails.

RESOLVED FIXED in 4.4.1

Status

NSPR
NSPR
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

4.4.1
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
The WINNT version of PR_Accept and PR_AcceptRead creates
a new socket (or gets one from its socket recycle list)
and calls AcceptEx to accept a new connection on the new
socket.

It does not close the socket or put the socket to the
socket recycle list when it fails.
(Assignee)

Comment 1

14 years ago
Created attachment 136256 [details] [diff] [review]
Proposed patch

Close the new socket if PR_Accept or PR_AcceptRead fails.
(Assignee)

Comment 2

14 years ago
Patch checked into the NSPR tip (4.5) and
NSPR_4_4_BRANCH (4.4.1).
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.4.1
(Assignee)

Comment 3

14 years ago
Comment on attachment 136256 [details] [diff] [review]
Proposed patch

Darin, if you don't have time to review this patch
this week, just cancel the review request.  Thanks.
Attachment #136256 - Flags: review?(darin)

Comment 4

13 years ago
Comment on attachment 136256 [details] [diff] [review]
Proposed patch

fwiw, r=darin
Attachment #136256 - Flags: review?(darin) → review+
You need to log in before you can comment on or make changes to this bug.