DOM testcases should use instanceof instead of .toString()

RESOLVED INCOMPLETE

Status

()

--
minor
RESOLVED INCOMPLETE
15 years ago
8 years ago

People

(Reporter: fabian, Assigned: fabian)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Assignee)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

Spun off from bug 135793. Caillon suggested to change the DOM testcases to use
instanceof instead of .toString().
This bug is to study and implement this idea.

Reproducible: Always

Steps to Reproduce:
1. Go to the above URL
2. Look at the source file(s)
3.

Actual Results:  
The testcase is using .toString()

Expected Results:  
The testcase should use instanceof

Let's just see how much work it is to convert alll the strings to interfaces
(sounds huge to me). If it's too big imho it's not worth the effort.
(Assignee)

Updated

15 years ago
Assignee: general → fabian

Updated

15 years ago
Summary: DOM testcases should use insteaceof instead of .toString() → DOM testcases should use instanceof instead of .toString()
(Assignee)

Updated

15 years ago
Depends on: 226823

Comment 1

12 years ago
The URL is 404 File Not Found. I wondered if this was related to bug 226823. If so, then we should resolve this bug as WORKSFORME.
QA Contact: ian → general

Comment 2

8 years ago
incomplete without testcase. 
but if something else makes better sense, please make the change.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.