bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

RecoverFloats repeatedly called despite no Floats in document.

NEW
Unassigned

Status

()

Core
Layout: Block and Inline
15 years ago
6 years ago

People

(Reporter: Ivan Eisen, Unassigned)

Tracking

(Depends on: 1 bug, {perf})

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
If no Floats have been discovered, why go and call
nsBlockReflowState::RecoverFloats.  My trace of a text document shows that
2.18% of the time is spent in RecoverFloats.  I don't have any floats within
the document that was traced.
Why not have a global float encounted switch to be checked
before  nsBlockReflowState::RecoverStateFrom calls RecoverFloats.  The very
first time a float is encountered set this switch.  Else,  don't ever call
the RecoverFloats routine.
(Reporter)

Updated

15 years ago
Summary: RecoverFloats repeatedly called dispite no Floats in document. → RecoverFloats repeatedly called despite no Floats in document.
(Reporter)

Comment 1

15 years ago
Created attachment 136292 [details]
Large text document
This has been discussed in the past, I know... I can't locate the bug where the
discussion happened.
(Reporter)

Comment 3

15 years ago
I am sure it was there at one time ; however, I also could not locate it.   The
problem does not seem as bad as it once was (some O(N^2) removed?).    
(Reporter)

Comment 4

15 years ago
I believe this was a long running topic in the performance newsgroup several
years ago.  I found bug 117374 (UpdateSpaceManager no longer needed) which
is related to the newsgroup discussion.

Ivan
Assignee: layout.block-and-inline → nobody
QA Contact: ian → layout.block-and-inline
You need to log in before you can comment on or make changes to this bug.