226893 - Code problem in /embedding/browser/activex/src/common/ControlEventSink.cpp

Status: RESOLVED EXPIRED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Wang Xianzhu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; ....

In the following code:
167     // Custom IID
168     m_EventIID = iidEventSink;
169     DWORD dwCookie = 0;
170     if (!ccp ||
171         FAILED(ccp->FindConnectionPoint(m_EventIID, &cp)) ||
172         FAILED(cp->Advise(this, &m_dwEventCookie)))
173     {
174         return E_FAIL;
175     }
176 
177     m_spEventCP = cp;
178     m_dwEventCookie = dwCookie;
179     m_spEventSinkTypeInfo = typeInfo;

m_dwEventCookie, which is used to Unadvise the event sink, is always 0 because
it is overridden by dwCookie.


Reproducible: Always

Steps to Reproduce:

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.