226932 - flag request email sends ' ' in subject

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Stephen Reindl]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 4.0; T312461)
Build Identifier: 

If you change a flag, the Subject line looks like '[Bug XXX]....'

The &nbsp should not be there

Reproducible: Always

Steps to Reproduce:
1. Open an Issue
2. apply a flag
3. wait for the flag update confirmation message

Actual Results:  
There are ' ' entities in the mail subject AND the text.

Expected Results:  
Use single spaces only

Comment 1

[Vlad Dascalu]

Related to bug 226527.

Comment 2

[Stephen Reindl]

Attachment: Use template logic instead of ' ' to provide spaces

The attached patch replaces the ' ' with template logic (i.e. put a plus
at the beginning of the template: [%+ keeps blanks on the left)

Comment 3

[Christian Reis]

Gerv, you added these  s to the email templates (I've seen them in others)
-- was this done intentionally, or did it end up sneaking into the big sweep you
did over at bug 13540?

Comment 4

[Christian Reis]

Comment on attachment 136418 [details] [diff] [review]
Use template logic instead of ' ' to provide spaces

Thanks for the patch.

For reference, it would be best if you provided unified diffs (diff -urNp work
nicely for me) as they are standard on the Mozilla project.

Comment 5

[J. Paul Reed [:preed]]

Just FYI, this patch will conflict with the patch for bug 84876. Ironically,
this patch touches code that is (right now) the last holdup for 84876 because...
I can't nail Myk down for the hours it will take to fix it.

Comment 6

[J. Paul Reed [:preed]]

Err... *two* hours it *would* take to fix it.

Comment 7

[Gervase Markham [:gerv]]

Yeah, must have been a mistake...

Gerv

Comment 8

[J. Paul Reed [:preed]]

Do you have something you'd like to say, Gerv?

Comment 9

[Dave Miller [:justdave]]

-> patch author

Comment 10

[Gervase Markham [:gerv]]

J.P.: Yes. I obviously didn't review [e-mail]'s patch for bug
13540 carefully enough :-)

Gerv

Comment 11

[Christian Reis]

Gone into the great melting pot:

/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/email.txt.tmpl,v
 <--  email.txt.tmpl
new revision: 1.4; previous revision: 1.3

Thanks, Stephen.