Closed Bug 227029 Opened 21 years ago Closed 21 years ago

nsExternalAppHandler dynamically allocates buffer for no reason

Categories

(Core Graveyard :: File Handling, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

Attachments

(1 file)

constructor:
1028   mDataBuffer = (char *) nsMemory::Alloc((sizeof(char) * DATA_BUFFER_SIZE));
destructor:
1037   if (mDataBuffer)
1038     nsMemory::Free(mDataBuffer);
no reallocations in between.
Attachment #136470 - Flags: superreview?(bz-vacation)
Attachment #136470 - Flags: review?(bz-vacation)
Status: NEW → ASSIGNED
Comment on attachment 136470 [details] [diff] [review]
patch

Yeah, makes sense.  r+sr=bzbarsky
Attachment #136470 - Flags: superreview?(bz-vacation)
Attachment #136470 - Flags: superreview+
Attachment #136470 - Flags: review?(bz-vacation)
Attachment #136470 - Flags: review+
Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.235; previous revision: 1.234
done
Checking in nsExternalHelperAppService.h;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.h,v  <-- 
nsExternalHelperAppService.h
new revision: 1.54; previous revision: 1.53
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: