GCC/Win32 build process bails on browser/app/module.rc:147 FILEVERSION

VERIFIED FIXED

Status

()

Firefox
Build Config
--
blocker
VERIFIED FIXED
15 years ago
14 years ago

People

(Reporter: Frederic Bezies, Assigned: Brian Ryner (not reading))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031202 Firebird/0.7+ (Pentium 4 gcc 3.3.1 optimized - MozJF)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031202 Firebird/0.7+ (Pentium 4 gcc 3.3.1 optimized - MozJF)

Simple. Keep your sources up to date, and try to build firebird with gcc 3.3.1
from mingw32. It was up-to-date at midnight mozilla.org time.

I've done twice make -f client.mk checkout to be sure not to be in a mid-checkin.

Reproducible: Always

Steps to Reproduce:
1.see details


Actual Results:  
Compilation is killed when creating firebird.exe !

Error is saying :

...\windres.exe : [path to sources]/browser/app/module.rc:147: syntax error

And then, build process kill itself :[



Expected Results:  
Making firebird exe.

Should be related to this ?

12/02/2003 23:10	ben%bengoodger.com 	mozilla/ browser/ app/ module.ver ?!


Yesterday, I built firebird using this .mozconfig without problem :|


CC=gcc
CXX=g++
CPP=cpp
AS=as
LD=ld

export MOZ_PHOENIX=1
mk_add_options MOZ_PHOENIX=1

ac_add_options --disable-ldap
ac_add_options --disable-mailnews
ac_add_options
--enable-extensions=cookie,xml-rpc,xmlextras,p3p,pref,transformiix,universalchardet,typeaheadfind,webservices,inspector
ac_add_options --enable-crypto
ac_add_options --disable-composer
ac_add_options --disable-profilesharing
ac_add_options --disable-installer

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../fbbuild

ac_add_options --disable-accessibility
ac_add_options --disable-debug
ac_add_options --disable-tests

ac_add_options --enable-strip

ac_add_options --enable-optimize="-Os -march=pentium4 -msse2 -mfpmath=sse
-ffast-math -ffloat-store -fforce-addr -ftracer"
(Reporter)

Comment 1

15 years ago
Additional infos : I thought my source was guilty. So I download (via CVS) a
brand new one. Same sad end :[
Flags: blocking0.8?
(Reporter)

Comment 2

15 years ago
It also breaks when I use --enable-optimize="-Os -march=i686"

:[
(Reporter)

Comment 3

15 years ago
Guilty line is saying :

FILEVERSION 0.7

Comment 4

15 years ago
Confirming on a setup more or less identical to Frederic's. Ben's recent
checkins to update version strings and such in Windows look suspect, I'll see if
I can't narrow it down.

Comment 5

15 years ago
windres expects the version string to be a quartet. 

Comment 6

15 years ago
Created attachment 136768 [details] [diff] [review]
Make FILEVERSION a quartet

Patch sets WIN32_MODULE_FILEVERSION=0.7.0.0 instead of 0.7.
(Reporter)

Comment 7

15 years ago
Getting patch. Making CVS update, applying patch and trying to a build. Result
in about 2 or 3 hours :]

Comment 8

15 years ago
Frederic,

I think my initial patch is incorrect. If it doesn't work (and I don't think it
will), try it changing to the following:

WIN32_MODULE_FILEVERSION=0,7,0,0

(note commas instead of dots)
(Reporter)

Comment 9

15 years ago
Ok. I will make a copy or your patch with "," instead of "." and I will tell
you. I am doing a checkout for now.

Comment 10

15 years ago
Created attachment 136779 [details] [diff] [review]
Make FILEVERSION a quartet

New patch with correct way of defining the quartet as per my previous comment
(commas instead of dots).
Attachment #136768 - Attachment is obsolete: true
(Reporter)

Comment 11

15 years ago
It works !

Thanks a lot !

Updated

15 years ago
Attachment #136779 - Flags: review?(bugs)
Comment on attachment 136779 [details] [diff] [review]
Make FILEVERSION a quartet

r=ben@mozilla.org
Attachment #136779 - Flags: review?(bugs) → review+

Comment 13

15 years ago
Fix checked in at 12:38pm today.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 14

15 years ago
Hmm ... although a patch has been checked in, its not the same patch that Ben
r+'ed over here. Someone with a GCC build environment on Windows should probably
test with a clean tree and see if it works, and reopen the bug if necessary.

Comment 15

15 years ago
Am reopening. The patch that Ben checked in sets
WIN32_MODULE_PRODUCTVERSION=0,7,0,0 and leaves WIN32_MODULE_FILEVERSION=0.7
intact (whereas my patch that Frederic tested does not define
WIN32_MODULE_PRODUCTVERSION but sets WIN32_MODULE_FILEVERSION=0,7,0,0). Based on
that fact that people are still reporting that the build is failing on
forums.mozillazine.org with an error in module.rc:147 I'm reopening until
someone with a GCC build environment on Win32 can confirm that it really is
fixed. Sorry for bugspam.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

15 years ago
Summary: Build process with Gcc-win32 is killed near the end :[ → GCC/Win32 build process bails on browser/app/module.rc:147 FILEVERSION
(Reporter)

Comment 16

15 years ago
Patch added sucks and kills build process in modules.rc:147 :|

Bad patch, change patch. Ali Ebrahim's one was working well.

Confirming that bug is still alive, so reopening was justified :[

Comment 17

15 years ago
Created attachment 136865 [details] [diff] [review]
New patch to fix new breakage. Remove PRODUCTVERSION and correct FILEVERSION.

This patch should fix the breakage as compared to the current state of CVS.
Ben's checkin appears to be incorrect, and this should fix that by removing
WIN32_MODULE_PRODUCTVERSION and correcting WIN32_MODULE_FILEVERSION.

Frederic can you confirm that this patch works on a freshly pulled clean CVS
tree?

Updated

15 years ago
Attachment #136779 - Attachment is obsolete: true

Comment 18

15 years ago
Created attachment 136867 [details] [diff] [review]
New patch to fix new breakage. Remove PRODUCTVERSION and correct FILEVERSION.

Replacing to remove some cruft that I had at the start of the patchfile. Sorry
for bugspam, I just woke up. :)
Attachment #136865 - Attachment is obsolete: true
(Reporter)

Comment 19

15 years ago
I am making a fresh CVS pull. And I will apply your patch.

I will tell you if building go to its end.
(Reporter)

Comment 20

15 years ago
This patch works (attachment 136867 [details] [diff] [review]). Please, check it in :)

Comment 21

15 years ago
Comment on attachment 136867 [details] [diff] [review]
New patch to fix new breakage. Remove PRODUCTVERSION and correct FILEVERSION.

Requesting review for attachment #136867 [details] [diff] [review].
Attachment #136867 - Flags: review?(bugs)
Comment on attachment 136867 [details] [diff] [review]
New patch to fix new breakage. Remove PRODUCTVERSION and correct FILEVERSION.

r=ben@mozilla.org
Attachment #136867 - Flags: review?(bugs) → review+

Comment 23

15 years ago
checked in
Status: REOPENED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → FIXED

Comment 24

15 years ago
Fix verified working on MSVC++ .NET 2003. File version is now correctly showing
0.7.0.0 instead of 0.0.0.0. It would be good if someone could also confirm on
GCC/MinGW.
Flags: blocking0.8?
(Reporter)

Comment 25

15 years ago
Confirming that it works perfectly. And properties are Ok :)

Comment 26

15 years ago
V
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.