227370 - [patch]The export bookmarks window should state "Export bookmarks to (HTML/Safari)"

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, enhancement)

Description

[Jasper]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6b) Gecko/20031202 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6b) Gecko/20031202 Camino/0.7+

The export bookmarks window is very vague, and should state more clearly what
the user can choose. 

It should state something like "Export bookmarks to (HTML/Safari)" instead of
just "(HTML/Safari)" 

Reproducible: Always

Steps to Reproduce:

Comment 1

[Ludovic Hirlimann [:Usul]]

Attachment: a two liner patch

Comment 2

[Jasper]

Oeps Ludo you made a spelling mistake :)

+  [button insertItemWithTitle:NSLocalizedString(@"Export bookmaarks to
Safari",@"Export bookmaarks to Safari") atIndex:1];

"bookmaarks" should be "bookmarks":

+  [button insertItemWithTitle:NSLocalizedString(@"Export bookmarks to
Safari",@"Export bookmarks to Safari") atIndex:1];

Comment 3

[Ludovic Hirlimann [:Usul]]

will correct that tonight.

Comment 4

[Ludovic Hirlimann [:Usul]]

Attachment: corrected typo

Comment 5

[Mike Pinkerton (not reading bugmail)]

how about changing the text from "save as" to "export to" and leave the
safari/html as is? seems more appropriate and is much less wordy. 

Comment 6

[S Woodside]

ludo this:
NSLocalizedString(@"Export bookmarks to Safari",@"Export bookmarks to Safari")
should be this:
NSLocalizedString(@"Export bookmarks to Safari",@"")

The second string is a "hint" which is given to the localization engineers to
help them translate. It never goes into the program. It's only supposed to be
filled in if there's some extra explanation that is needed to translate the info.

fix that and I'll review + I think this is better than before.

Comment 7

[Josh Aas]

Attachment: the way it should be

Apply this patch to MainController.mm and add the line:

"Export to:" = "Export to:";

to Localizable.strings. This will make the export panel look right. I hand
coded the UI widgets - you can do it with a nib if you want but I don't want to
do it that way. If nothing else this patch will show you what you need to do.

Comment 8

[Josh Aas]

Attachment: patch v1.0

Here is a patch done right using a nib interface instead of hand-coded. Just
replace the files in the archive in your tree. 1 nib, 1 header, 1
implementation file changed.

Comment 9

[Mike Pinkerton (not reading bugmail)]

josh, can you make a patch instead of uploading the files? it's much much much
easily to apply if you do. you can upload a separate attachment for the nib.

Comment 10

[Josh Aas]

Attachment: nib for patch v1.1

Comment 11

[Josh Aas]

Attachment: patch v1.1

Comment 12

[Josh Aas]

Attachment: new nib file v1.2

Comment 13

[Josh Aas]

Attachment: Import/Export accessory view patch v1.2

Apply this patch, add the new nib file to your project, remove mFilterView from
MainMenu.nib (the view AND the reference to it in MainController's nib
representation)

Comment 14

[Mike Pinkerton (not reading bugmail)]

landed with some tweaks.