227745 - search plugin dropmarker doesn't match default theme

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Greg Campbell]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031207 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031207 Firebird/0.7+

The search dropmarker should look similar to the default back and forward
dropmarkers: centered vertically and separated from the icon horizontally. The
current marker is at the baseline and slightly overlapping the icon.

Reproducible: Always

Steps to Reproduce:




This dropmarker should (possibly) be themeable so that the look can match any
installed theme.

Comment 1

[miahz]

this is pretty easily fixed.  not sure if there's a reason it was put
half-overlapping the icon to start with.  so the question is: was there a
reason/should it be changed?

as for themeability - it already is.  pretty much everything is.  but it's up to
the theme makers to customize it.  several themes have already corrected this.


tho it would definitely jack up themes, another idea would be to make the search
icon into a menu-type button with a separate dropmarker.  you could use the
dropmarker to select the engine from the popup, then click the icon itself to
trigger the search.  then you wouldn't need a separate "search" button for
mouse-clickers.

Comment 2

[miahz]

Attachment: patch fixing search dropmarker positioning

dropmarker clears the right edge of the search icon, and is vertically
centered.

but noticed something else while figuring this out:  the search bar looks like
**** in the palette.

Comment 3

[Greg Campbell]

someone should probably review the patch. If it works (and it looks good to me),
it would make good polish for 1.0.

Comment 4

[Greg Campbell]

On second glance... margin: 3px 0 4px 16px; looks a little better centered with
the current image. And shouldn't it be .searchbar-dropmarker-image?

Also, to match the default theme, the dropdown arrow should be smaller (like the
ones for back and forward).

I think I'll CC Kevin Gerich on this one.

Comment 5

[Greg Campbell]

Changes tracked in bug 335435, particularly bug 335441, may also fix this bug.

Comment 6

[Greg Campbell]

This appears to be fixed by the visual refresh for Firefox 2 (bug 345407). At least it looks right in the last couple nightlies.