Closed Bug 227904 Opened 21 years ago Closed 20 years ago

Windows link warnings

Categories

(SeaMonkey :: Build Config, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stdowa+bugzilla, Unassigned)

Details

Attachments

(2 files, 1 obsolete file)

AccessibleMarshal.exp : warning LNK4070: /OUT:ISimpleDOMDocumentMarshal.dll
directive in .EXP differs from output filename "AccessibleMarshal.dll"; ignoring
directive
nsOEFactory.obj : warning LNK4042: object specified more than once; extras ignored
Attached patch patch (obsolete) — Splinter Review
Attachment #137096 - Flags: review?(bryner)
Comment on attachment 137096 [details] [diff] [review]
patch

accessible part looks ok.  r=me on that.

for the OE import stuff, it looks like what should happen is that
nsOEFactory.cpp is removed from the main CPPSRCS list and is only appended if
MOZ_STATIC_MAIL_BUILD is not defined.
Attachment #137096 - Flags: review?(bryner) → review-
Attached patch patch v1.1Splinter Review
Attachment #137096 - Attachment is obsolete: true
Attachment #137428 - Flags: review?(bryner)
Attachment #137428 - Flags: review?(bryner) → review+
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: EXETYPE statement not supported for the target platform; ignored
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: SUBSYSTEM statement not supported for the target platform; ignored
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: STUB statement not supported for the target platform; ignored
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: CODE statement not supported for the target platform; ignored
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: DATA statement not supported for the target platform; ignored

All these statements appear to only be valid when building a VxD.
Attachment #138897 - Attachment description: Fix the zlib.def warnings → Fix the zlib.def warnings
Attachment #138897 - Flags: review?(bryner)
I'm not familiar enough with .def files to know what these statements would mean.
Comment on attachment 138897 [details] [diff] [review]
Fix the zlib.def warnings

Passing onto leaf, who I think knows more about the Windows build.  Does this
break anything?
Attachment #138897 - Flags: review?(bryner) → review?(leaf)
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore/html/_core_module.2d.definition_files.asp
 is the link to the statement I posted in comment 4.

Additionally, VC 2003 generates a LNK4017 warning for DESCRIPTION while VC 6
(creature's log) does not.
Product: Browser → Seamonkey
Comment on attachment 138897 [details] [diff] [review]
Fix the zlib.def warnings

Leaf's no longer around; let's just get this in.
Attachment #138897 - Flags: review?(leaf) → review+
actually, this was fixed by zlib 1.2.1.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: