227904 - Windows link warnings

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Stephen Walker]

AccessibleMarshal.exp : warning LNK4070: /OUT:ISimpleDOMDocumentMarshal.dll
directive in .EXP differs from output filename "AccessibleMarshal.dll"; ignoring
directive
nsOEFactory.obj : warning LNK4042: object specified more than once; extras ignored

Comment 1

[Stephen Walker]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 137096 [details] [diff] [review]
patch

accessible part looks ok.  r=me on that.

for the OE import stuff, it looks like what should happen is that
nsOEFactory.cpp is removed from the main CPPSRCS list and is only appended if
MOZ_STATIC_MAIL_BUILD is not defined.

Comment 3

[Stephen Walker]

Attachment: patch v1.1

Comment 4

[Stephen Walker]

c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: EXETYPE statement not supported for the target platform; ignored
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: SUBSYSTEM statement not supported for the target platform; ignored
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: STUB statement not supported for the target platform; ignored
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: CODE statement not supported for the target platform; ignored
c:/builds/tinderbox/WINNT_5.0_Clobber/mozilla/modules/zlib/src/zlib.def :
warning LNK4017: DATA statement not supported for the target platform; ignored

All these statements appear to only be valid when building a VxD.

Comment 5

[Stephen Walker]

Attachment: Fix the zlib.def warnings

Comment 6

[Brian Ryner (not reading)]

I'm not familiar enough with .def files to know what these statements would mean.

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 138897 [details] [diff] [review]
Fix the zlib.def warnings

Passing onto leaf, who I think knows more about the Windows build.  Does this
break anything?

Comment 8

[Stephen Walker]

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore/html/_core_module.2d.definition_files.asp
 is the link to the statement I posted in comment 4.

Additionally, VC 2003 generates a LNK4017 warning for DESCRIPTION while VC 6
(creature's log) does not.

Comment 9

[Brian Ryner (not reading)]

Comment on attachment 138897 [details] [diff] [review]
Fix the zlib.def warnings

Leaf's no longer around; let's just get this in.

Comment 10

[Brian Ryner (not reading)]

actually, this was fixed by zlib 1.2.1.