The default behavior for mozilla is supposed to be to forward messages as attachments. If no user pref exists for mail.forward_message_mode, then messages are forwarded as attachments. However, on the "messages" pref screen, if the pref is not set then "Inline" shows up as the default. Changing any pref on this screen has the side effect of setting the forward mode to "Inline" which is not the intended default. It looks like the possible values of mail.forward_message_mode are 0 and 2. 0 = forward as attachment 2 [details] [diff] [review] = forward inline
I'm not sure how default prefs are actually supposed to get selected, but listing the default first seems to work.
it looks like adding this pref to all.js instead is the right thing
taking this from hangas. I'll look into it right now.
dawn is right. all we need to do here is specify the default. I added the default to mailnews.js, instead of all.js, since it is a mailnews pref. we don't have to change the xul file, if the default pref is specified, the right html option will be selected. fixed.
actually, dawn is right, we do need to switch the order of the options. we need to change the order of the options because if the user had "forward as quoted", we want it to look like "forward as attachment", because "forward as quoted" is obsolete. The back end will behave like "forward as attachment", and this makes it so the front end will too. alternatively, we could change the pref migration code to turn mail.forward_message_mode to 0, if it was 1, but I have a feeling "forward as quoting" will come back one day, so this is the better fix.
http://bugzilla.mozilla.org/show_bug.cgi?id=20267 may be related?
Hmm, this reminds me.... The default behaviour (when mail.forward_message_mode is not set) is to forward as attachment. However if that pref is set to something invalid, then you get set to forwarding as inline. If your forwarding mode is going to be something you didn't ask for, it seems like it should be set to the default. if (forwardType == 2) MsgForwardAsInline(null); else MsgForwardAsAttachment(null);
Seth, is this fixed? You marked it fixed on 12-29 @ 10:22, but then there are comments after that, that indicate it's not fixed to do the right thing. BTY...what is the right thing?
yes, this bug should be closed. my Jan 3 comments are really a seperate bug, which i filed last night. (bug 23098)
Using builds 20000104 on win98, mac and linux this is fixed. Tested by migrating a (3) 4.7 profiles, each with a different default setting for fowarding: Quoted, migrated to As Attachment in 5.0 Inline, migrated to Inline in 5.0 As Attachment, migrated to As Attachment in 5.0 I believe this is the correct behavior, Verified endico, using the above tests, Forward as Quoted (which is invalid for 5.0) is correctly migrating to Forward as Attachment for the Jan 4 builds. Is this test verifying your new bug too. Note: I just checked the preference setting after the migration, I didn't actually forward a message.