default forward_message_mode not set correctly

VERIFIED FIXED in M13

Status

SeaMonkey
MailNews: Message Display
P3
normal
VERIFIED FIXED
18 years ago
13 years ago

People

(Reporter: Dawn Endico, Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
The default behavior for mozilla is supposed to be to forward messages as
attachments. If no user pref exists for mail.forward_message_mode, then
messages are forwarded as attachments.

However, on the "messages"  pref screen, if the pref is not set then "Inline"
shows up as the default. Changing any pref on this screen has the side effect
of setting the forward mode to "Inline" which is not the intended default.


It looks like the possible values of mail.forward_message_mode are 0 and 2.
0 = forward as attachment
2 [details] [diff] [review] = forward inline
(Reporter)

Comment 1

18 years ago
Created attachment 3875 [details] [diff] [review]
patch to change order of select options
(Reporter)

Comment 2

18 years ago
I'm not sure how default prefs are actually supposed to get selected,
but listing the default first seems to work.
(Reporter)

Comment 3

18 years ago
Created attachment 3876 [details] [diff] [review]
add a pref to all.js
(Reporter)

Comment 4

18 years ago
it looks like adding this pref to all.js instead is the right thing
Assignee: hangas → sspitzer
taking this from hangas.  I'll look into it right now.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
dawn is right.

all we need to do here is specify the default.

I added the default to mailnews.js, instead of all.js, since it is a mailnews
pref.

we don't have to change the xul file, if the default pref is specified, the
right html option will be selected.

fixed.
Target Milestone: M13
marking m13.
actually, dawn is right, we do need to switch the order of the options.

we need to change the order of the options
because if the user had "forward as quoted", we want it to look like
"forward as attachment", because "forward as quoted" is obsolete.
The back end will behave like "forward as attachment", and this makes it so the
front end will too.

alternatively, we could change the pref migration code to turn
mail.forward_message_mode to 0, if it was 1, but I have a feeling "forward as
quoting" will come back one day, so this is the better fix.

Updated

18 years ago
QA Contact: lchiang → esther

Comment 9

18 years ago
http://bugzilla.mozilla.org/show_bug.cgi?id=20267 may be related?
(Reporter)

Comment 10

18 years ago
Hmm, this reminds me....


The default behaviour (when mail.forward_message_mode is not set) is to forward
as attachment. However if that pref is set to something invalid, then you get
set to forwarding as inline. If your forwarding mode is going to be something
you didn't ask for, it seems like it should be set to the default.


if (forwardType == 2)
         MsgForwardAsInline(null);
   else
         MsgForwardAsAttachment(null);

Comment 11

18 years ago
Seth, is this fixed?  You marked it fixed on 12-29 @ 10:22, but then there are
comments after that,  that indicate it's not fixed to do the right thing.
BTY...what is the right thing?
(Reporter)

Comment 12

18 years ago
yes, this bug should be closed. my Jan 3 comments are really
a seperate bug, which i filed last night. (bug 23098)

Updated

18 years ago
Status: RESOLVED → VERIFIED

Comment 13

18 years ago
Using builds 20000104 on win98, mac and linux this is fixed.  Tested by
migrating a (3) 4.7 profiles, each with a different default setting for
fowarding:
Quoted,  migrated to As Attachment in 5.0
Inline,  migrated to Inline in 5.0
As Attachment, migrated to As Attachment in 5.0

I believe this is the correct behavior, Verified

endico, using the above tests, Forward as Quoted (which is invalid for 5.0) is
correctly migrating to Forward as Attachment for the Jan 4 builds.  Is this test
verifying your new bug too.  Note:  I just checked the preference setting after
the migration, I didn't actually forward a message.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.