Closed Bug 227914 Opened 21 years ago Closed 21 years ago

Warpsans bold fonts are not printed bold.

Categories

(Core :: Printing: Output, defect)

All
OS/2
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: grajaman, Assigned: grajaman)

Details

(Keywords: fixed1.4.2)

Attachments

(3 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031114 Firebird/0.7+
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6b) Gecko/20031111

 The warpsans bold fonts in the testcase are not printed bold on OS/2.

Reproducible: Always

Steps to Reproduce:
1. Load the testcase and print it.
2.  
3.
Actual Results:  
The bold fonts are not printed bold.

Expected Results:  
It should have printed bold.
Attached file Testcase
OS: other → OS/2
Status: NEW → ASSIGNED
Assignee: printing → grajaman
Status: ASSIGNED → NEW
Attached patch PatchSplinter Review
javier: In getvectorsubstitute() I substitute Warpsans with Helvetica. Please
have a look.
Comment on attachment 137103 [details] [diff] [review]
Patch

This looks fine to me

r=mkaply
sr=blizzard (platform specific)
Attachment #137103 - Flags: superreview+
Attachment #137103 - Flags: review+
Status: NEW → ASSIGNED
Comment on attachment 137103 [details] [diff] [review]
Patch

a=mkaply for 1.4.2 and 1.6
Attachment #137103 - Flags: approval1.6+
Attachment #137103 - Flags: approval1.4.2+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Keywords: fixed1.4.2
This was a very bad fix.

It caused us to substitute Helvetica for WarpSans in a lot of situations.

We need to make this ONLY for printing. getVectorSubstitute is used for screen
as well.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reassign to myself I'll debug this.
Status: REOPENED → NEW
Status: NEW → ASSIGNED
Attached patch patch for reviewSplinter Review
I have made the above changes for only printing under
if(mDeviceContext->SupportsRasterFonts())
Attachment #140069 - Flags: review?(pedemont)
Attachment #140069 - Flags: review?(pedemont) → review+
Comment on attachment 140069 [details] [diff] [review]
patch for review

sr=blizzard (platform specific)
a=mkaply for 1.4.2 (OS/2 specific)
Attachment #140069 - Flags: superreview+
Attachment #140069 - Flags: approval1.4.2+
refixed
Status: ASSIGNED → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: