Closed
Bug 227914
Opened 21 years ago
Closed 21 years ago
Warpsans bold fonts are not printed bold.
Categories
(Core :: Printing: Output, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: grajaman, Assigned: grajaman)
Details
(Keywords: fixed1.4.2)
Attachments
(3 files)
1.24 KB,
text/html
|
Details | |
614 bytes,
patch
|
mkaply
:
review+
mkaply
:
superreview+
mkaply
:
approval1.4.2+
mkaply
:
approval1.6+
|
Details | Diff | Splinter Review |
1.21 KB,
patch
|
jhpedemonte
:
review+
mkaply
:
superreview+
mkaply
:
approval1.4.2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031114 Firebird/0.7+
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6b) Gecko/20031111
The warpsans bold fonts in the testcase are not printed bold on OS/2.
Reproducible: Always
Steps to Reproduce:
1. Load the testcase and print it.
2.
3.
Actual Results:
The bold fonts are not printed bold.
Expected Results:
It should have printed bold.
javier: In getvectorsubstitute() I substitute Warpsans with Helvetica. Please
have a look.
Comment 4•21 years ago
|
||
Comment on attachment 137103 [details] [diff] [review]
Patch
This looks fine to me
r=mkaply
sr=blizzard (platform specific)
Attachment #137103 -
Flags: superreview+
Attachment #137103 -
Flags: review+
Comment 5•21 years ago
|
||
Comment on attachment 137103 [details] [diff] [review]
Patch
a=mkaply for 1.4.2 and 1.6
Attachment #137103 -
Flags: approval1.6+
Attachment #137103 -
Flags: approval1.4.2+
Comment 6•21 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•21 years ago
|
Keywords: fixed1.4.2
Comment 7•21 years ago
|
||
This was a very bad fix.
It caused us to substitute Helvetica for WarpSans in a lot of situations.
We need to make this ONLY for printing. getVectorSubstitute is used for screen
as well.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•21 years ago
|
||
I have made the above changes for only printing under
if(mDeviceContext->SupportsRasterFonts())
Updated•21 years ago
|
Attachment #140069 -
Flags: review?(pedemont)
Updated•21 years ago
|
Attachment #140069 -
Flags: review?(pedemont) → review+
Comment 11•21 years ago
|
||
Comment on attachment 140069 [details] [diff] [review]
patch for review
sr=blizzard (platform specific)
a=mkaply for 1.4.2 (OS/2 specific)
Attachment #140069 -
Flags: superreview+
Attachment #140069 -
Flags: approval1.4.2+
Comment 12•21 years ago
|
||
refixed
Status: ASSIGNED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•