227914 - Warpsans bold fonts are not printed bold.

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Ganesh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031114 Firebird/0.7+
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6b) Gecko/20031111

 The warpsans bold fonts in the testcase are not printed bold on OS/2.

Reproducible: Always

Steps to Reproduce:
1. Load the testcase and print it.
2.  
3.
Actual Results:  
The bold fonts are not printed bold.

Expected Results:  
It should have printed bold.

Comment 1

[Ganesh]

Attachment: Testcase

Comment 2

[Ganesh]

Attachment: Patch

Comment 3

[Ganesh]

javier: In getvectorsubstitute() I substitute Warpsans with Helvetica. Please
have a look.

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 137103 [details] [diff] [review]
Patch

This looks fine to me

r=mkaply
sr=blizzard (platform specific)

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 137103 [details] [diff] [review]
Patch

a=mkaply for 1.4.2 and 1.6

Comment 6

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 7

[Mike Kaply [:mkaply]]

This was a very bad fix.

It caused us to substitute Helvetica for WarpSans in a lot of situations.

We need to make this ONLY for printing. getVectorSubstitute is used for screen
as well.

Comment 8

[Ganesh]

Reassign to myself I'll debug this.

Comment 9

[Ganesh]

Attachment: patch for review

Comment 10

[Ganesh]

I have made the above changes for only printing under
if(mDeviceContext->SupportsRasterFonts())

Comment 11

[Mike Kaply [:mkaply]]

Comment on attachment 140069 [details] [diff] [review]
patch for review

sr=blizzard (platform specific)
a=mkaply for 1.4.2 (OS/2 specific)

Comment 12

[Mike Kaply [:mkaply]]

refixed