Warpsans bold fonts are not printed bold.

RESOLVED FIXED

Status

()

RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: grajaman, Assigned: grajaman)

Tracking

({fixed1.4.2})

Trunk
All
OS/2
fixed1.4.2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031114 Firebird/0.7+
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6b) Gecko/20031111

 The warpsans bold fonts in the testcase are not printed bold on OS/2.

Reproducible: Always

Steps to Reproduce:
1. Load the testcase and print it.
2.  
3.
Actual Results:  
The bold fonts are not printed bold.

Expected Results:  
It should have printed bold.
(Assignee)

Comment 1

15 years ago
Created attachment 137102 [details]
Testcase
(Assignee)

Updated

15 years ago
OS: other → OS/2
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

15 years ago
Assignee: printing → grajaman
Status: ASSIGNED → NEW
(Assignee)

Comment 2

15 years ago
Created attachment 137103 [details] [diff] [review]
Patch
(Assignee)

Comment 3

15 years ago
javier: In getvectorsubstitute() I substitute Warpsans with Helvetica. Please
have a look.

Comment 4

15 years ago
Comment on attachment 137103 [details] [diff] [review]
Patch

This looks fine to me

r=mkaply
sr=blizzard (platform specific)
Attachment #137103 - Flags: superreview+
Attachment #137103 - Flags: review+
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED

Comment 5

15 years ago
Comment on attachment 137103 [details] [diff] [review]
Patch

a=mkaply for 1.4.2 and 1.6
Attachment #137103 - Flags: approval1.6+
Attachment #137103 - Flags: approval1.4.2+

Comment 6

15 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

15 years ago
Keywords: fixed1.4.2

Comment 7

15 years ago
This was a very bad fix.

It caused us to substitute Helvetica for WarpSans in a lot of situations.

We need to make this ONLY for printing. getVectorSubstitute is used for screen
as well.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

15 years ago
Reassign to myself I'll debug this.
Status: REOPENED → NEW
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 9

15 years ago
Created attachment 140069 [details] [diff] [review]
patch for review
(Assignee)

Comment 10

15 years ago
I have made the above changes for only printing under
if(mDeviceContext->SupportsRasterFonts())

Updated

15 years ago
Attachment #140069 - Flags: review?(pedemont)

Updated

15 years ago
Attachment #140069 - Flags: review?(pedemont) → review+

Comment 11

15 years ago
Comment on attachment 140069 [details] [diff] [review]
patch for review

sr=blizzard (platform specific)
a=mkaply for 1.4.2 (OS/2 specific)
Attachment #140069 - Flags: superreview+
Attachment #140069 - Flags: approval1.4.2+

Comment 12

15 years ago
refixed
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.