227979 - Editkeywords.cgi HTML validation

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Vlad Dascalu]

The newly checked-in patches need minor modifications to pass the HTML
validation checker. Thanks kiko for the validation tip :)

Comment 1

[Vlad Dascalu]

Attachment: Patch

Comment 2

[Christian Reis]

Comment on attachment 137158 [details] [diff] [review]
Patch

>Index: template/en/default/admin/keywords/create.html.tmpl
>+  <input type="hidden" name="id" value="-1">
>   <input type="submit" value="Add">
>   <input type="hidden" name="action" value="new">

I don't see how we actually need this id here, but it goes beyond the scope of
this bug.

Comment 3

[Dave Miller [:justdave]]

what's the "id" hidden field for?

Comment 4

[Vlad Dascalu]

Attachment: Version 2

Ok, I checked and it seems it wasn't used anywhere. I inspected the code and
the functionability via browser and removing that line seems to be okay.

Comment 5

[Vlad Dascalu]

Comment on attachment 137161 [details] [diff] [review]
Version 2

This will generate a warning due to our attempt to detaint the id in all cases.

Comment 6

[Vlad Dascalu]

I recommend per kiko's suggestion to checkin the HTML-validation thing and worry
about removing the unused "-1" in a later patch.

Comment 7

[Vlad Dascalu]

Checking in template/en/default/admin/keywords/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/keywords/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/keywords/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.2; previous revision: 1.1
done