227993 - no toolbar in venkman/fb0.7

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Robert Ginda]

it seems that the toolbar doesn't show up in venkman on fb 0.7.

I'm strapped for time these days, can someone vend me a clue?

Comment 1

[Robert Ginda]

Attachment: screenshot

Comment 2

[Scott MacGregor]

this is caused by toolkit api changes for xbl bindings.  

You probably need to make a change like the following:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mail/base/skin&command=DIFF_FRAMESET&root=/cvsroot&file=communicator.css&rev1=1.7&rev2=1.8

Comment 3

[Robert Ginda]

but I don't have any specific toolbar binding in venkman.css, I just rely on the
browser knowing what a <toolbar> is.

Comment 4

[Pierre Chanial]

rginda: could you tell me what are the steps you follow to install venkman in
Firebird? and which xpi? I'll have a look at it.

Comment 5

[Robert Ginda]

http://www.hacksrus.com/~ginda/venkman/

visit that url, click the most recent install link and restart firebird.  you
can  start venkman by typing x-jsd:debugger in the url bar.

Comment 6

[Pierre Chanial]

What happens is the following: the "maintoolbar" that is missing and should
contain the icons has the class "toolbar-primary".
communicator.css binds this class to the binding
"...toolbar.xml#toolbar-primary" that exists in the xpfe toolkit but not in the
new one.

This binding has been introduced in the xpfe toolkit in september 2002 to fix
bug 22056: "Show toolbars as text/icons/both". Since we already had this
functionality, I didn't include this binding when I merged the xpfe fixes in the
new toolkit in august.

Then, that's not stricly speaking a XUL 1.0 violation and as far as I know,
there is nothing about a "toolbar-primary".

The problem will disappear as soon as Firebird doesn't ship the file
communicator.css, because the rule that binds to a non-existent binding will
disappear. I plan to dump all the "chrome://communicator/*" and
"chrome://navigator/*" files in the 0.9 timeframe.
Doing it today would be risky.

However I'd be really happy to see Venkman functional for 0.8.
I am not sure what's the best to do. If the class "toolbar-primary" is removed,
the icons will be back in Firebird, but in seamonkey, the toolbar won't obey the
 pref "text/icon/both".

Comment 7

[Pierre Chanial]

maybe the best thing to do would be to add a junk "toolbar-primary" binding in
the new toolkit and remove it as soon as we don't ship communicator.css.

Comment 8

[chris hofmann]

I'm going to plus this so it gets on the radar.  Are we to the point where
someone can cobble together the patch?  would need to get it reviewed and landed
soon.

Comment 9

[Pierre Chanial]

A better fix would have been to move the -moz-binding communicator.css rule into
xul.css, but the modern theme use its own toolbar-primary...

I added the following binding to toolbar.xml:

+  // for now, empty binding to deal with -moz-binding rules from communicator.css
+  // (see bug 227993) we may need that binding one day to propagate
+  // the text/icons/both state to other windows. If we don't, this binding
+  // should be removed after we stop shipping the seamonkey communicator.css
skin files.
+  <binding id="toolbar-primary"
extends="chrome://global/content/bindings/toolbar.xml#toolbar"/>

taking.

Comment 10

[Pierre Chanial]

and marking fixed.