Closed Bug 228040 Opened 19 years ago Closed 19 years ago

make the new add bookmarks dialog resizable

Categories

(Firefox :: Bookmarks & History, enhancement)

x86
Windows XP
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firebird0.8

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

Details

Attachments

(1 file)

The dialog retains its size. So it should be resizable. This helps to see more
of your bookmarks tree. This also makes bug 227951 less severe, because you can
narrow the dialog again.
Attached patch patchSplinter Review
Changes the callers of addBookmarks2.xul from resizable=no to resizable.
Also changes dialog=yes to dialog (that's the same, isn't it?) and removes
centerscreen.

According to http://www.mozilla.org/xpfe/xulref/windowref.html#opendialog
dialog and chrome are on by dafault in openDialog, but I left these in.
Attachment #137180 - Flags: review?(p_ch)
Comment on attachment 137180 [details] [diff] [review]
patch

right, dialog defaults to "yes"
Attachment #137180 - Flags: review?(p_ch) → review+
I didn't noticed that because linux doesn't honor the option "resizable=no".
checked in.
Thanks Pierre. Marking fixed.
What was wrong with the removal of "centerscreen"?
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firebird0.8
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.