228095 - AIX: 64-bit build error in nsScriptSecurityManager.cpp

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[Philip K. Warren]

On AIX, I am getting the following error trying to build
nsScriptSecurityManager.cpp in 64-bit:

"/home/pkw/sb/mozilla/1.6b/mozilla/caps/src/nsScriptSecurityManager.cpp", line
667.62: 1540-0216 (S) An expression of type "nsIURI *" cannot be converted to
type "PRBool".
gmake[4]: *** [nsScriptSecurityManager.o] Error 1
gmake[4]: Leaving directory `/home/pkw/sb/mozilla/1.6b/mozilla/obj-opt64/caps/src'
gmake[3]: *** [libs] Error 2

This is the line it is bailing on:

rv = CheckSameOriginDOMProp(subjectPrincipal, objectPrincipal,
                            aAction, (PRBool)aTargetURI);

This was added in Bug 163950, and it looks like Brendan's review comment was
just missed when checking in this fix:

"Isn't aTargetURI a pointer?  You can't just cast to (PRBool) (which is to say,
to (int)), and get a valid boolean.  Best to use aTargetURI != nsnull here."

Comment 1

[Philip K. Warren]

Attachment: Patch v1

Patch which addresses Brendan's comment (and fixes the 64-bit build).

Comment 2

[Brendan Eich [:brendan]]

Let's get the patch reviewed (caillon and I can r= and sr=) and checked in for
1.6 final.

/be

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 137210 [details] [diff] [review]
Patch v1

/me hates it when review comments don't get addressed right away.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 137210 [details] [diff] [review]
Patch v1

I don't check to see that my review comments are addressed, esp. when the patch
submitter acknowledged my point!  But then I don't trust everyone equally; I
was hashing everyone into the "trusted" bucket.

/be

Comment 5

[Philip K. Warren]

Fixed.

Checking in nsScriptSecurityManager.cpp;
/cvsroot/mozilla/caps/src/nsScriptSecurityManager.cpp,v  <-- 
nsScriptSecurityManager.cpp
new revision: 1.224; previous revision: 1.223
done