228118 - When adding vCard to address book, home address gets placed in work address field.

Status: RESOLVED WORKSFORME

(MailNews Core :: Address Book, defect)

Description

[Chris Ilias [:cilias]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031208
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031205 Thunderbird/0.4

If you click on the "Add to Personal Address Book" button beside a vCard that is
atteached to a message, the vCard's Home address field gets placed in the work
address field, even when there is a separate work addresses contained in the vCard.

Reproducible: Always

Steps to Reproduce:
1. Send an email to yourself with a vCard attached, containing a work address
and a home address.
2. Get your message, and set the view message body to "original HTML".
3. Click on the "Add to Personal Address Book" button.

Actual Results:  
The home address gets placed in the work address field.

Expected Results:  
The work address from the vCard should go in the work address field; and the
home address from the vCard should go in the home address field.

Tested with a POP3 account.
In order to get separate addresses in the vCard, I exported a card from my
Windows Address Book as a vCard file (VCF), then attached it to the message when
composing.

Comment 1

[Renaud Bonneville]

...and Thunderbird doesn't take the email address and city (the email is printed
in the message body).
Renaud (Mozilla Thunderbird 0.5 (20040207), Windows 2000)

Comment 2

[Brian]

When creating or editing a vCard, under the 'Address' tab there isn't a way to
input a 'Home' address... only 'Work'.  Missing a scrollbar??

Comment 3

[Mark Banner (:standard8)]

*** Bug 272575 has been marked as a duplicate of this bug. ***

Comment 4

[ceyquem]

Actually, there is no possibility to put your personal address book in a vCard
(while it is possible to read it in vCard received by mail !!) and you can only
put your professionnal address.

I would rename this Bug to : Can't put home address when creating vCard (only
professionnal address field available)

Comment 5

[Robert Pollak]

The repeatedly mentioned topic of not being able to input a 'Home' address is not this bug but bug 247154.

Comment 6

[heinz.repp]

Even with 2.0.0.16 import from an attached vcard is severely broken: home address is imported as work address, an email with attribute PREF (preferred) is discarded, and the alternative email address is imported as the preferred one. As these bugs (247154 and this one) have been around for pretty long time, always waiting for someone to take over and never assigned to a core developer, it is clear that vcard support in the core is considered very low priority if any. I suggest it should better be dropped at all, as buggy as it is. Fortunately there is a capable extension that does things right (MoreColsForAddressbook). Using it works, but even then it is too tempting to double click an attached vcard, and then data loss is probable, so removing this function would prevent it.

Comment 7

[Heinrich.Baum]

Still present in Thunderbird 3.0.1 - Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1 .
Why?

There is also a very special charset / encoding bug.
If I have a vcard in a mail like this:
Content-Type: text/x-vcard; charset=UTF-8;
 name="test.vcf"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
 filename="test.vcf"

BEGIN:VCARD
VERSION:3.0
N;CHARSET=UTF-8:Bäum;Heinrich
FN;CHARSET=UTF-8:Heinrich Bäum
END:VCARD


When I double click on it and then in the vcard-window given name and name is right, but display name is Heinrich B=C3=A4um !

Comment 9

[dvhttn]

Update: just tested Thunderbird 13.0.1 importing vcards from Outlook 2010 and the problem still persists.

This is the extract from the vcf file (Version 2.1 it says - I've changed the actual address details - as it's mine!! - but everything else is identical):

======================
ADR;HOME;PREF;ENCODING=QUOTED-PRINTABLE:;;9, Wxxxxxxx Yyyyyyy=0D=0A=
Hhhhhhhhhh;Ttttt;Cccccccc;YH7 9UU;United Kingdom
LABEL;HOME;PREF;ENCODING=QUOTED-PRINTABLE:9, Wxxxxxxx Yyyyyyy=0D=0A=
Hhhhhhhhhh=0D=0A=
Ttttt=0D=0A=
Cccccccc=0D=0A=
YH7 9UU
X-MS-OL-DEFAULT-POSTAL-ADDRESS:1
=========================

This gets read by Tbird as the WORK address - every time. If the address is labelled as WORK then it gets imported as WORK though.

I'm a little perplexed as to why this bug should still be around after so long. If people want to change from an Outlook environment they need the tools to be able to import that environment into TBird and, at the moment, some simple things seem to be lacking.

Comment 10

[dvhttn]

Had occasion to test this again. This time I used a vcard generated on an Android phone and emailed it to the Thunderbird account I mention above. The same thing happens - the private address is placed in the work address tab. The vcard is as here - this is the complete vcard (as visible in NotePad++ ), all I have changed are the actual personal details but the character count remains the same.

==========================
BEGIN:VCARD
VERSION:2.1
N:Hxxxxxx;Jack;;;
FN:Jack Hxxxxxx
TEL;CELL;PREF:[phone]
TEL;HOME:[phone]
EMAIL;PREF:[e-mail]
ADR;HOME:;;27 Ffffffffff Cccccccc;Ggggggg;Hhhhhh;HY45 7FD;United Kingdom
END:VCARD
========================

Comment 11

[quenenni]

I noticed that the problem is TB takes the last ADR line and insert it as the work address whatever the type is and doesn't do anything with the others.

Case 1:
ADR;HOME:;;rue xxx, 73;yyy;;1210;Belgique
ADR;WORK:;;rue zzz, 35;aaa;;1060;Belgique

In TB, no home address inserted and work address is "rue zzz, 35 - 1060"

Case 2:
ADR;WORK:;;rue zzz, 35;aaa;;1060;Belgique
ADR;HOME:;;rue xxx, 73;yyy;;1210;Belgique

In TB, no home address inserted and work address is "rue xxx, 73 - 1210"


I tried also with the types DOM, POSTAL, PARCEL and nothing seems to matter..

Comment 12

[Lukas Rechberger]

Attachment: Patch

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8712617 [details] [diff] [review]
Patch

Apologies for the unacceptable delay on this. I clearly don't have the cycles for this. :/ Redirecting to Magnus.

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 8712617 [details] [diff] [review]
Patch

I'll be taking this review since Magnus is too busy.

I tested this patch with this test data:
BEGIN:VCARD
VERSION:2.1
N:Hxxxxxx;Jack;;;
FN:Jack Hxxxxxx
TEL;CELL;PREF:[phone]
TEL;HOME:[phone]
EMAIL;PREF:[e-mail]
ADR;WORK:;;rue work, 35;aaa;;1060;Belgique
ADR;HOME:;;rue home, 73;yyy;;1210;Belgique
END:VCARD

as suggested in comment #10 and comment #11.

I even added some debug to the code:

  else if (PL_strcasecmp(VCStreetAddressProp, vObjectName(vObj)) == 0)
  {
    printf("=== Street address: %s %d\n", VCStreetAddressProp, isAPropertyOf(vObj, VCHomeProp)?1:0);
    if (isAPropertyOf(vObj, VCHomeProp))
      cardPropName = kHomeAddressProperty;
    else
      cardPropName = kWorkAddressProperty;
  }

What I see on the debug console is this:
=== Street address: street 0
=== Street address: street 0

So it appears that what you try to do doesn't work. I get "rue home, 73" as work address.

Can you tell me what I'm doing wrong and check that the patch works for you.

I also noticed that address book export also doesn't export home and work address as desired. Only the work address gets exported.

So it looks like there is quite a bit of work required here.

Comment 15

[Jorg K (CEST = GMT+2)]

Comment on attachment 8712617 [details] [diff] [review]
Patch

Clearing the review for now since I did review it and unless I'm missing something, the patch doesn't work. So please investigate the problem and submit a new patch requesting review from me (which you will get within 48 hours).

Comment 16

[Geoff Lankow (:darktrojan)]

This has been fixed in Thunderbird 78 by bug 1639430 and friends.