Closed Bug 228501 Opened 21 years ago Closed 21 years ago

Warning ``redeclaration of var i'' in file ``chrome://messenger/content/mailWidgets.xml'', line 1002, character 21.

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.7alpha

People

(Reporter: timeless, Assigned: neil)

Details

Attachments

(1 file, 1 obsolete file)

Make the JS match the C++
1.82 KB, patch
Bienvenu
: review+
mscott
: superreview+
Details | Diff | Splinter Review 
Warning ``redeclaration of var i'' [xs] in file
``chrome://messenger/content/mailWidgets.xml'', line 1002, character 21.
Attached patch remove second declaration (obsolete) — — Splinter Review 

    
  

        Attachment #137433 -
        Flags: review?(neil.parkwaycc.co.uk)

    
    

    
  


  
I rewrote the other search header extraction so not only did I remove the first
declaration of i but it actually works with junk in the pref e.g. this patch
correctly interprets " : : Foo : : Bar : : " as ["Foo","Bar"] as per the C++.

    
  

        Attachment #137448 -
        Flags: superreview?(mscott)

        Attachment #137448 -
        Flags: review?(bienvenu)

    
  

        Attachment #137448 -
        Flags: superreview?(mscott) → superreview+

    
  

        Attachment #137448 -
        Flags: review?(bienvenu) → review+

    
    

    
  
Mine :-)
Assignee: timeless → neil.parkwaycc.co.uk
Target Milestone: --- → mozilla1.7alpha

    
  

        Attachment #137433 -
        Flags: review?(neil.parkwaycc.co.uk)

    
    

    
  
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

        Attachment #137433 -
        Attachment is obsolete: true
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: