228618 - nssPKIObject_RemoveInstanceForToken uses realloc incorrectly.

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

nssPKIObject_RemoveInstanceForToken uses realloc incorrectly.

        object->instances = nss_ZREALLOCARRAY(object->instances,
                                              nssCryptokiObject *,
                                              object->numInstances);
        if (!object->instances) {
            PZ_Unlock(object->lock);
            return PR_FAILURE;
        }

There are two problems.

1. It would lose the pointer to the previously allocated memory
block if realloc returns NULL.

2. We are using realloc to shrink the array here.  Failure to
shrink the array should be ignored.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

This patches fixes the two problems described above.
It also fixes an unused variable compiler warning.

Comment 2

[Wan-Teh Chang]

Fix checked in.

Checking in pkibase.c;
/cvsroot/mozilla/security/nss/lib/pki/pkibase.c,v  <--  pkibase.c
new revision: 1.22; previous revision: 1.21
done

Comment 3

[Serge Gautherie (:sgautherie)]

*** Bug 221128 has been marked as a duplicate of this bug. ***