228621 - nsprpub/configure doesn't work with Solaris/gcc 2.95

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I just got the Solaris tinderboxes running again, and it seems that
nsprpub/configure is being generated using a version of autoconf that has an
extended version of AC_PROG_CXX that doesn't work correctly on Solaris.  In
particular, it generates command lines like:

gcc -o now.o -c     -Wall -pthreads -O -fPIC  -UDEBUG  -DMOZILLA_CLIENT=1
-DNDEBUG=1 #ifdef\ __cplusplus void\ exit\ \(int\)\; #endif -DXP_UNIX=1 -DSVR4=1
-DSYSV=1 -D__svr4=1 -D__svr4__=1 -DSOLARIS=1 -DHAVE_FCNTL_FILE_LOCKING=1
-D_PR_HAVE_OFF64_T=1 -D_LARGEFILE64_SOURCE=1 -D_PR_INET6=1 -DHAVE_LCHOWN=1
-DHAVE_STRERROR=1 -D_REENTRANT=1 -DHAVE_POINTER_LOCALTIME_R=1  -DFORCE_PR_LOG
-D_PR_PTHREADS -UHAVE_CVAR_BUILT_ON_SEM   now.c

(Notice the extra #ifdef...#endif)

I suspect generating the configure using a standard autoconf 2.13 (plus adding
the one modification you make manually afterwards for the MKS Korn Shell) would
fix this problem, although my build to test that this is the case is still going
(it's on the worms tinderbox on SeaMonkey-Ports).

This change to configure landed in:
 * trunk: revision 1.151 (2003-11-24)
 * NSPRPUB_PRE_4_2_CLIENT_BRANCH: revision 1.78.2.73 (2003-12-15)

This does not look like a problem on MOZILLA_1_4_BRANCH (pkw landed the patch
there).

Comment 1

[Wan-Teh Chang]

David, I ran autoconf on Red Hat Linux 7.2.  If you can attach
the configure file generated by the right version of autoconf,
I will check it in.  (I can take care of the MKS fixup.)  Thanks.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: diff to configure for NSPRPUB_PRE_4_2_CLIENT_BRANCH

Comment 3

[Wan-Teh Chang]

Fixed checked in.  Thanks for the patch, David.

Comment 4

[Asa Dotzler [:asa]]

Is this resolved for SeaMonkey? (I'd like to remove the blocking1.6? flag if it
is). If not, what needs to happen for SeaMonkey to get this fix?

Comment 5

[Wan-Teh Chang]

This is resolved for SeaMonkey.  Removed the blocking1.6? flag.