228803 - The contextual menu item "Open Tabs in New Window" does not work

Status: VERIFIED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Derek Schrock]

When you open a contextual menu for a folder that's in the bookmark toolbar one
of the items you can choose from is "Open Tabs in New Window." This menu item
isn't working. I have tried with a clean profile thinking it was something in
prefs.js or user.js and I get the same resault (Nothing happens)

Steps:
1. Open a contextual menu for a folder that's in your bookmarks toolbar menu
2. Choose "Open Tabs in New Window"

Comment 1

[Josh Aas]

From BookmarkButton.mm:

  // if we get to this else, we better be a group.  check just in case i'm wrong.
  else if ([item isKindOfClass:[BookmarkFolder class]]) {
    if ([(BookmarkFolder *)item isGroup]) {
      [brController openNewWindowWithGroupURLs:[(BookmarkFolder *)item
childURLs] loadInBackground: loadInBackground];
    }
  }

He was wrong :)

Problem is this fails when I think it should not:
if ([(BookmarkFolder *)item isGroup]) {

Simon?

Comment 2

[S Woodside]

If memory serves me correctly I have a patch around somewhere that might fix
this. IIRC isGroup checks to see if a folder is a tab group. I don't think that
we need that any more though, openNewWindowWithGroupURLs I think will still work
even even if [item isGroup] is FALSE.

Comment 3

[Josh Aas]

Attachment: patch v1.0

This fixes the problem for me - its based on woodside's comment.

Comment 4

[Ludovic Hirlimann [:Usul]]

Comment on attachment 138520 [details] [diff] [review]
patch v1.0

Patch is unecessary, My official 2004010403 build knows how to open, multiples
tabs from a folder in the background. However I have a folder containing two
folders, and choose to open that foldre ina a new tab nothing happens.

Comment 5

[Ludovic Hirlimann [:Usul]]

Comment on attachment 138520 [details] [diff] [review]
patch v1.0

Grrr Why did I opened the bookmark views to test this. Ignore above comment.

Comment 6

[Mike Pinkerton (not reading bugmail)]

landed

Comment 7

[Chris Petersen]

Verified fixed in the 2004011103 NB under 10.3.2