Closed Bug 228846 Opened 21 years ago Closed 15 years ago

"Created an attachment" should not be part of attachment hyperlink

Categories

(Bugzilla :: Attachments & Requests, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: u20230201, Assigned: mkanat)

References

Details

(Whiteboard: [blocker will fix])

User-Agent:       Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030821
Build Identifier: 

When creating an attachment, an automatic comment sayng "Created an attachment
(id=X)" is created. This is suboptimal for the following reasons:

1) The whole text is converted to a hyperlink, but the phrase "Created an "
should not be part of the hyperlink (the link refers to the attachment, not to
the creation).

2) When hovering with the mouse over a referenced bug id, the title attribute
causes the summary of the bug being displayed ("tooltip help"). This should be
done for attachments as well, just to be consistent (i.e. display the
"Description").

3) If the automatically generated test would include the comment the user
specified when creating the attachment, the bug mails about an attachment being
created would be much more useful. If done that way, the suggested change "2)"
could be modified to display the attachment "Comment" instead of the attachment
"Description".

Reproducible: Always

Steps to Reproduce:
One could change the text to
Created <a href>attachment XXXX</a>

but I don't see what is gained by that. I can tell you what is lost, which is
that you can't jump around the bug just reading comments near attachments, like
the one that prompted the attachment to be created.

Sure you can put the original comment into the tip, but often that's silly. I
frequently change the attachment description or filename later, but that doesn't
mean it's significantly more useful.
a) these are three different bugs, they should be filed separately.

b) notes:
   2) this is already bug 110751
   3) Bugzilla already does this.  Unless you didn't say what you meant.  What you
      described is what it already does.

c) since that leaves us with 1), modifying summary to indicate that alone, and
this bug will only be about that.

confirming non-duplicate rfe
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Change comment "Created an attachment" in various ways → "Created an attachment" should not be part of attachment hyperlink
note that by jumped i mean using typeaheadfind or an equivalent for "Created an
attachment" ctrl-g - and if you have a bug where the text is inconsistent you
cause real headaches for people who do this :)
To clarify: What I had in mind was replacing (hypothetical example follows)
<a href=...>Created an attachment (id=X)</a>
with
Created <a href=... title=$DESCRIPTION>attachment id=X ($DESCRIPTION)</a>
where "$DESCRIPTION" is the description displayed in the "Attachment" section.
It's a matter of taste whether "</a> should be put before or after the
description. Another matter of taste is whether the "title" attribute should be
$DESCRIPTION (the description) or $COMMENT (the comment for the attachmant).

The suggested change was intended to reduce the requirement for excessive
scrolling back and forth in longer bug reports.
Re Dave's comment 2: well, bug 110751 actually refers to adding a title to the
"attachment XXX" link, not the "Created an attachment" link.

Having said that, I disagree with having a title that just duplicates the
comment or description in the "Created an attachment" link, given that it's
already available as text and we shouldn't have the same message in two
different places in the UI.

I think request 1) is reasonable and trivial to implement, if somebody would
like to provide a patch.

I don't understand timeless' point, though -- the fact that the words "Created
an" are linked or not doesn't seem to have any effect on typeaheadfind or find.
QA Contact: mattyt-bugzilla → default-qa
Assignee: myk → attach-and-request
Assignee: attach-and-request → mkanat
Depends on: 452919
Whiteboard: [blocker will fix]
Target Milestone: --- → Bugzilla 3.6
Fixed by blocker.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.