229076 - rdf should not be built is MOZ_XUL isn't defined.

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect)

Description

[Doug Turner (:dougt)]

Well, that isn't entirely true;  This is a bandaide around the way the build
handles static builds:  Any component library file built during the "build" will
be added to the list of final links.  Ideally, this list should be able to be
specified by the build ahead of time, but for most devleopers this isn't need 
So, since I am only considered with rdf, and we are already using the
MOZ_XUL_APP to get rid of the chrome component, I figured it would be fine if I
did something similar to the RDF component.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Benjamin Smedberg]

dougt: for reference, my new packaging branch allows one to use configure
options to select which components/libraries to statically link (thus fixing the
static build hackery in embedding/browser/gtkembed).

Is this minimo-only? We need RDF for the fat global history and bookmarks
services, entirely apart from whether we use XUL.

Comment 3

[Doug Turner (:dougt)]

this is minimo only.  (not the patch doesn't correctly work.  I need a new one
that exports the cid's header)

When will your new packaging stuff land?  I am tempted to push a workaround
patch until your stuff hits the trunk.

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 5

[Benjamin Smedberg]

doug: can't we make this ifndef MOZ_MINIMO instead of MOZ_XUL? The patch as it
stands would probably break camino, and perhaps other embedding apps.

I'm planning on landing the packaging branch as soon as I get a couple clear
days to clean up regressions and watch the tree, which probably won't be until
5-Jan.

Comment 6

[Doug Turner (:dougt)]

i could make it ifdef MINIMO.  With that, darin could i get a SR, benjamin could
I get a r=?

Comment 7

[Benjamin Smedberg]

Comment on attachment 137806 [details] [diff] [review]
patch v.2

r=me for minimo (you really don't need sr, this is build-config and doesn't
affect the seamonkey build). Is the extra space in the EXPORT_LIBRARY line an
accident?

Comment 8

[Doug Turner (:dougt)]

this was checked in.