If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

rdf should not be built is MOZ_XUL isn't defined.

RESOLVED FIXED

Status

()

Core
RDF
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

976 bytes, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
Well, that isn't entirely true;  This is a bandaide around the way the build
handles static builds:  Any component library file built during the "build" will
be added to the list of final links.  Ideally, this list should be able to be
specified by the build ahead of time, but for most devleopers this isn't need 
So, since I am only considered with rdf, and we are already using the
MOZ_XUL_APP to get rid of the chrome component, I figured it would be fine if I
did something similar to the RDF component.
(Assignee)

Comment 1

14 years ago
Created attachment 137776 [details] [diff] [review]
patch v.1

Comment 2

14 years ago
dougt: for reference, my new packaging branch allows one to use configure
options to select which components/libraries to statically link (thus fixing the
static build hackery in embedding/browser/gtkembed).

Is this minimo-only? We need RDF for the fat global history and bookmarks
services, entirely apart from whether we use XUL.
(Assignee)

Comment 3

14 years ago
this is minimo only.  (not the patch doesn't correctly work.  I need a new one
that exports the cid's header)

When will your new packaging stuff land?  I am tempted to push a workaround
patch until your stuff hits the trunk.
(Assignee)

Comment 4

14 years ago
Created attachment 137806 [details] [diff] [review]
patch v.2
Attachment #137776 - Attachment is obsolete: true

Comment 5

14 years ago
doug: can't we make this ifndef MOZ_MINIMO instead of MOZ_XUL? The patch as it
stands would probably break camino, and perhaps other embedding apps.

I'm planning on landing the packaging branch as soon as I get a couple clear
days to clean up regressions and watch the tree, which probably won't be until
5-Jan.
(Assignee)

Comment 6

14 years ago
i could make it ifdef MINIMO.  With that, darin could i get a SR, benjamin could
I get a r=?

Comment 7

14 years ago
Comment on attachment 137806 [details] [diff] [review]
patch v.2

r=me for minimo (you really don't need sr, this is build-config and doesn't
affect the seamonkey build). Is the extra space in the EXPORT_LIBRARY line an
accident?
Attachment #137806 - Flags: review+
(Assignee)

Comment 8

14 years ago
this was checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.