The following file copied nsIModule. Please use the macro NS_IMPL_NSGETMODULE instead. D:\cmonkey\mozilla\intl\chardet\src\nsCharDetModule.cpp(149): D:\cmonkey\mozilla\intl\compatibility\src\nsI18nCompatibility.cpp(177): D:\cmonkey\mozilla\intl\locale\src\unix\nsLocaleModule.cpp(129): D:\cmonkey\mozilla\intl\lwbrk\src\nsLWBrkModule.cpp(129): D:\cmonkey\mozilla\intl\strres\src\nsStringBundle.cpp(506): D:\cmonkey\mozilla\intl\uconv\src\nsUConvModule.cpp(101): D:\cmonkey\mozilla\intl\uconv\ucvcn\nsUCvCnModule.cpp(313): D:\cmonkey\mozilla\intl\uconv\ucvja\nsUCvJaModule.cpp(347): D:\cmonkey\mozilla\intl\uconv\ucvko\nsUCvKoModule.cpp(281): D:\cmonkey\mozilla\intl\uconv\ucvlatin\nsUCvLatinModule.cpp(976): D:\cmonkey\mozilla\intl\uconv\ucvtw\nsUCvTwModule.cpp(271): D:\cmonkey\mozilla\intl\uconv\ucvtw2\nsUCvTw2Module.cpp(361): D:\cmonkey\mozilla\intl\unicharutil\src\nsUcharUtilModule.cpp(150):
dp, please provide details about this bug. We have no idea what you talk about.
Sure frank. Look at xpcom/sample/nsSampleModule.cpp We have embarked on a macro version of factory and module. A lot of code for these can go away. Converting to the above template will reduce our dll size. Dougt has converted a lot of them. I did a few before the holidays. The ones that dougt didnt convert have bugs I think. (BTW thanks doug)
nsUcharUtilModule.cpp fix in my tree and send to dp for code review. nsUcv*Module.cpp, nsCharDetModule.cpp depend on 23350 I will work on nsI18nCompatibility.cpp, nsLocaleModule.cpp, nsStringBundle.cpp and nsUConvModule.cpp first.
nsI18nCompatibility.cpp is fix in my tree. Send to dp and nhotta for review.
Noooo!!!! Please don't do this indiscriminately!!! In some of the cases, we are using our own Module object some reasons: at initialization time we are writing stuff into the registry, we delete that stuff at the end and we create components in a certain way. The places where we are doing that are: uconv and the ucv* DLLs. So please don't change those. Thanks, Cata
archive the r1.2 based nsUConvModule.cpp since cata ask me to hold it.
Cannot fix all the module by m13. Move it to M14.
reassign to jbetak
Assignee: ftang → jbetak
Status: ASSIGNED → NEW
ftang, What is the status on this? Which modules have we updated and checked-in? Is this bug a Beta1 stopper?
This is not a beta1 stopper. there are other more important things to do. (IMO)
Move this to M15
Target Milestone: M14 → M15
jbetak- I suggest you do nsUCvCnModule.cpp first.
*** Bug 32792 has been marked as a duplicate of this bug. ***
*spam* changing qa contact from email@example.com to me (BlakeR1234@aol.com) on 121 open or resolved (but not verified) bugs. sorry for the spam everybody, but most of these bugs would just remain dormant and not checked by QA otherwise. I'm not sure how so many bugs have nobody as their QA contact, but I suspect this is the fault of some sort of bugzilla corruption that happened at some point (most of these bugs are in the 20000-26000 range, and I don't see where in the activity log that QA contact explicitly changed to firstname.lastname@example.org) Anyways, sorry again for spam. If you really get annoyed, I'm usually available in #mozilla on IRC for torture.
QA Contact: nobody → BlakeR1234
reassigning to ftang for resource reallocation
Assignee: jbetak → ftang
Status: ASSIGNED → NEW
mark nsbeta3 and perf
Status: NEW → ASSIGNED
Keywords: nsbeta3, perf
nsbeta3- per i18n bug meeting. dp- what is your opinion. we are open to re-evaluate this bug for nsbeta3 if you think it is very important.
If this will help performance and code footprint (the main goals of beta3), why nsbeta3- ?
yea, I'm asking for reconsideration.
The following module are done nsI18nCompatibility ucvtw ucvja nsLWBrkModule nsStringBundle nsUcharUtilModule The following are not done uconv ucvtw2 ucvko ucvlatin ucvcn ucvibm nsCharDetModule nslocale nsI18nCompatibility dp said he don't think this is important.
dp - why now does this not matter. Your comments on 01-03: We have embarked on a macro version of factory and module. A lot of code for these can go away. Converting to the above template will reduce our dll size. I think now more than ever, DLL size is important.
Marking as nsbeta3- per I18N Bug Triage. DP told Ftang that this issue is not of high importance.
I, the reporter, and DP inital comment disagree with this.
nsbeta3- per i18n bug meeting. I don't think we have enough time to fix and test this.
reassign to yokoyama plese try to fix ucvtw2 ucvko ucvcn first. and then ucvlatin ucvibm
Assignee: ftang → yokoyama
Status: ASSIGNED → NEW
Frank: Some of the charsets (eg. UnicodeToISO2022KR) in nsUCvKoCID.h are not in nsUCvKoModule.cpp. Is this correct?
Created attachment 20381 [details] [diff] [review] Ooops, compiler error. Here is the update. Disregard the previous attachement (ucvtw2)
Cata: How can I verify the conversion? I can view a Korean site with my patch, but I don't think it's good enough. Do you have a test plan for all the encodings? adding email@example.com to cc
nice work! r=valeski on the 12/08/00 16:42 and 12/08/00 17:32 patches.
nice work again. r=valeski on 12/12/00 10:30 patch
It's ok, testing with a page using the respective encoding is the best test.
Cata: Do you have a list of URLs for respective encodings? I checked against home.netscape.com/ja, /ko etc and Yahoo.
Nope. You should ask Kat, I'm sure he has.
cc'ing: momoi-san momoi-san: Do you have a list of URLs to do a quick testing on Char Encodings?
<offtopic> Changing keywords, clobbering milestone. yokoyama could you or a manager select a current target milestone (mozilla0.8 currently is the next milestone, other candidates include mozilla0.9 and mozilla1.0). fwiw, these days we're moving towards using cvsblame to show authorship instead of inline ownership marks. + * The Original Code is Mozilla Communicator client code. Do we say this elsewhere? </offtopic>
Keywords: nsbeta3 → approval, mozilla1.0, patch
Target Milestone: M18 → ---
Created attachment 20939 [details] [diff] [review] ucvlatin converted module (16/16) - This is too much. I hope I didn't make any mistake:)
Could someone review the code? - ucvtw2 : reviewed by Jud (2000-12-11 10:34) - ucvko : reviewed by Jud (2000-12-11 10:34) - ucvcn : reviewed by Jud (2000-12-12 10:38) - cvlatin : need a review - ucvibm : need a review Momoi-san: do we have URLs to test respective encodings?
Some internal sites which contain charset tests: http://slip/i18n_client/browser/fonts/multibyte_tests/ http://babel/tests/Browser/charset/ You will find EUC-TW CNS planes 1 & 2 here: http://slip/i18n_client/browser/fonts/multibyte_tests/euc-tw/euc-tw.html I don't think we have too many IBM code pages for testing internally. One that comes to my mind is Cyrillic 866 at: http://babel/tests/Browser/charset/charset_test.html
Created attachment 21215 [details] [diff] [review] Correction for (12/18/00 17:47) ucvlatin converted module
Frank: as per our code review, please /r for the new ucvlatin as well as ucvibm. Thanks
/sr by ftang. This is a big change. I'll notify iQA by email and keep my eyes open for any new issues.
What about ucvmath!?
firstname.lastname@example.org < can you review the code for me?
To test the rendering International fonts, please go to http://babel/tests/dogfood/templates/top_intl_urls.htm
I didn't applied the patch. But I have scanned it and couldn't spot at anything suspicious. r=rbs.
Updating the target milestone.
Target Milestone: --- → mozilla0.8
ftang: can you /sr= for the ucvmath (01/22/01 15:13)?
for ucvmath sr=ftang
All the modules are checked in. :) Please verify. Thanks
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
I need to convert uconv.dll and others as well. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We have little more module to do: nsUconvModule nsChardetModule nsLocaleModule nsLwbrkModule nsUCharUtilModule
Revising the list of components left: nsUconvModule - need to use NS_GETMODULE nsChardetModule (67576 will resolve this) nsLocaleModule - need to use NS_GETMODULE nsLwbrkModule - already done nsUCharUtilModule - already done I am going to file new bugs for nsLocaleModule and nsUConvModule. I hate to attach patches to this bug after seeing long list of patches attached. :)
I filed 2 new bugs: 74438 nor -- All email@example.com NEW nsUconvModule - need to use NS_GETMODULE 74439 nor -- All firstname.lastname@example.org NEW nsLocaleModule - need to use NS_GETMODULE email@example.com> please close this bug.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago → 18 years ago
Resolution: --- → INVALID
Attachment #20923 - Attachment description: ucvlatin converted module (16 more files to add:nsISO88596EToUnicode.cpp, nsISO88596EToUnicode.h, nsISO88596IToUnicode.cpp, nsISO88596IToUnicode.h, nsISO88598EToUnicode.cpp,nsISO88598EToUnicode.h, nsISO88598IToUnicode.cpp, nsISO88598IToUnicode.h, nsUnicod → ucvlatin converted module (16 more files to add)
You need to log in before you can comment on or make changes to this bug.